You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/17 12:12:10 UTC
[GitHub] [dubbo] BurningCN opened a new pull request #8840: Add test case for ZookeeperMetadataReportTest
BurningCN opened a new pull request #8840:
URL: https://github.com/apache/dubbo/pull/8840
## What is the purpose of the change
1.test case
2.fix typo
3.remove unused param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #8840: Add test case for ZookeeperMetadataReportTest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8840:
URL: https://github.com/apache/dubbo/pull/8840#issuecomment-921782569
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8840?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8840](https://codecov.io/gh/apache/dubbo/pull/8840?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e2878) into [3.0](https://codecov.io/gh/apache/dubbo/commit/1b100f84cb51a590c865e2d28d159b4d4c203409?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b100f8) will **increase** coverage by `0.02%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/dubbo/pull/8840?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8840 +/- ##
============================================
+ Coverage 63.70% 63.72% +0.02%
Complexity 312 312
============================================
Files 1145 1169 +24
Lines 48188 49202 +1014
Branches 7255 7360 +105
============================================
+ Hits 30699 31355 +656
- Misses 14123 14417 +294
- Partials 3366 3430 +64
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8840?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../dubbo/common/utils/ServiceAnnotationResolver.java](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvU2VydmljZUFubm90YXRpb25SZXNvbHZlci5qYXZh) | `56.25% <ø> (-1.33%)` | :arrow_down: |
| [...g/apache/dubbo/metadata/report/MetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnQuamF2YQ==) | `14.28% <ø> (ø)` | |
| [...ubbo/metadata/store/nacos/NacosMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtcmVwb3J0LW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9zdG9yZS9uYWNvcy9OYWNvc01ldGFkYXRhUmVwb3J0LmphdmE=) | `0.00% <ø> (ø)` | |
| [...ubbo/metadata/store/redis/RedisMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtcmVwb3J0LXJlZGlzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9zdG9yZS9yZWRpcy9SZWRpc01ldGFkYXRhUmVwb3J0LmphdmE=) | `24.35% <ø> (ø)` | |
| [...adata/store/zookeeper/ZookeeperMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtcmVwb3J0LXpvb2tlZXBlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0YWRhdGEvc3RvcmUvem9va2VlcGVyL1pvb2tlZXBlck1ldGFkYXRhUmVwb3J0LmphdmE=) | `71.05% <ø> (+1.31%)` | :arrow_up: |
| [...ient/metadata/store/RemoteMetadataServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvbWV0YWRhdGEvc3RvcmUvUmVtb3RlTWV0YWRhdGFTZXJ2aWNlSW1wbC5qYXZh) | `65.27% <0.00%> (ø)` | |
| [...adata/rest/ClassPathServiceRestMetadataReader.java](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXN0L0NsYXNzUGF0aFNlcnZpY2VSZXN0TWV0YWRhdGFSZWFkZXIuamF2YQ==) | `87.50% <100.00%> (ø)` | |
| [...ubbo/registry/client/ServiceDiscoveryRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvU2VydmljZURpc2NvdmVyeVJlZ2lzdHJ5LmphdmE=) | `82.11% <100.00%> (+0.11%)` | :arrow_up: |
| [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| ... and [273 more](https://codecov.io/gh/apache/dubbo/pull/8840/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8840?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8840?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1b100f8...77e2878](https://codecov.io/gh/apache/dubbo/pull/8840?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #8840: Add test case for ZookeeperMetadataReportTest
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #8840:
URL: https://github.com/apache/dubbo/pull/8840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a change in pull request #8840: Add test case for ZookeeperMetadataReportTest
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #8840:
URL: https://github.com/apache/dubbo/pull/8840#discussion_r712323509
##########
File path: dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/MetadataReport.java
##########
@@ -45,7 +45,7 @@
default void publishAppMetadata(SubscriberMetadataIdentifier identifier, MetadataInfo metadataInfo) {
}
- default MetadataInfo getAppMetadata(SubscriberMetadataIdentifier identifier, Map<String, String> instanceMetadata) {
+ default MetadataInfo getAppMetadata(SubscriberMetadataIdentifier identifier) {
Review comment:
Please do not change this method signature. `instanceMetadata` contains some instance releated properties which will take effect when getting metadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org