You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-commits@db.apache.org by cl...@apache.org on 2026/07/03 23:18:59 UTC
(db-jdo) branch main updated: JDO-861 Finding 4: Replace deprecated Class.newInstance() in getEnhancer
This is an automated email from the ASF dual-hosted git repository.
clr-apache pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/db-jdo.git
The following commit(s) were added to refs/heads/main by this push:
new fd6d4ca4 JDO-861 Finding 4: Replace deprecated Class.newInstance() in getEnhancer
fd6d4ca4 is described below
commit fd6d4ca454ed2c9d23726a8bd3033f59bbd52b1d
Author: Craig L Russell <ap...@gmail.com>
AuthorDate: Fri Jul 3 16:15:41 2026 -0700
JDO-861 Finding 4: Replace deprecated Class.newInstance() in getEnhancer
Use getDeclaredConstructor().newInstance() instead of the Java 9+
deprecated newInstance() to ensure proper exception handling and
constructor accessibility checks.
Co-Authored-By: Claude Sonnet 4.6 <no...@anthropic.com>
---
api/src/main/java/javax/jdo/JDOHelper.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/api/src/main/java/javax/jdo/JDOHelper.java b/api/src/main/java/javax/jdo/JDOHelper.java
index ab17ab92..aa1d0601 100644
--- a/api/src/main/java/javax/jdo/JDOHelper.java
+++ b/api/src/main/java/javax/jdo/JDOHelper.java
@@ -1590,7 +1590,7 @@ public class JDOHelper implements Constants {
try {
String enhancerClassName = getClassNameFromURL(urls.nextElement());
Class<?> enhancerClass = forName(enhancerClassName, true, ctrLoader);
- return (JDOEnhancer) enhancerClass.newInstance();
+ return (JDOEnhancer) enhancerClass.getDeclaredConstructor().newInstance();
} catch (Exception ex) {
// remember exceptions from failed enhancer invocations
exceptions.add(ex);
Re: (db-jdo) branch main updated: JDO-861 Finding 4: Replace deprecated Class.newInstance() in getEnhancer
Posted by Craig Russell <ap...@gmail.com>.
This is the first time I've used claude to push changes to github, so we are literally in uncharted waters.
Instead of creating a branch, I pushed this direct to main. I have not seen any indication that this triggered a CI run.
I'll keep watching but it's been half an hour. Do we need to add a CI rule for direct pushes to main? Or do we wait until github and gitbox sync?
Craig
> On Jul 3, 2026, at 16:18, clr@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> clr-apache pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/db-jdo.git
>
>
> The following commit(s) were added to refs/heads/main by this push:
> new fd6d4ca4 JDO-861 Finding 4: Replace deprecated Class.newInstance() in getEnhancer
> fd6d4ca4 is described below
>
> commit fd6d4ca454ed2c9d23726a8bd3033f59bbd52b1d
> Author: Craig L Russell <ap...@gmail.com>
> AuthorDate: Fri Jul 3 16:15:41 2026 -0700
>
> JDO-861 Finding 4: Replace deprecated Class.newInstance() in getEnhancer
>
> Use getDeclaredConstructor().newInstance() instead of the Java 9+
> deprecated newInstance() to ensure proper exception handling and
> constructor accessibility checks.
>
> Co-Authored-By: Claude Sonnet 4.6 <no...@anthropic.com>
> ---
> api/src/main/java/javax/jdo/JDOHelper.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/api/src/main/java/javax/jdo/JDOHelper.java b/api/src/main/java/javax/jdo/JDOHelper.java
> index ab17ab92..aa1d0601 100644
> --- a/api/src/main/java/javax/jdo/JDOHelper.java
> +++ b/api/src/main/java/javax/jdo/JDOHelper.java
> @@ -1590,7 +1590,7 @@ public class JDOHelper implements Constants {
> try {
> String enhancerClassName = getClassNameFromURL(urls.nextElement());
> Class<?> enhancerClass = forName(enhancerClassName, true, ctrLoader);
> - return (JDOEnhancer) enhancerClass.newInstance();
> + return (JDOEnhancer) enhancerClass.getDeclaredConstructor().newInstance();
> } catch (Exception ex) {
> // remember exceptions from failed enhancer invocations
> exceptions.add(ex);
>
Craig L Russell
clr@apache.org