You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/20 19:09:45 UTC
[GitHub] [spark] jiangxb1987 commented on a change in pull request #27972:
[SPARK-31207][CORE] Ensure the total number of blocks to fetch equals to
the sum of local/hostLocal/remote blocks
jiangxb1987 commented on a change in pull request #27972: [SPARK-31207][CORE] Ensure the total number of blocks to fetch equals to the sum of local/hostLocal/remote blocks
URL: https://github.com/apache/spark/pull/27972#discussion_r395839801
##########
File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -91,8 +91,7 @@ final class ShuffleBlockFetcherIterator(
private val targetRemoteRequestSize = math.max(maxBytesInFlight / 5, 1L)
/**
- * Total number of blocks to fetch. This should be equal to the total number of blocks
Review comment:
This is no longer true since we merge remote blocks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org