You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/08/07 22:34:58 UTC
[kudu-CR] [tablet] acquire a lock for DCHECK() only in debug build
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16310
Change subject: [tablet] acquire a lock for DCHECK() only in debug build
......................................................................
[tablet] acquire a lock for DCHECK() only in debug build
Change-Id: I5b3ffe76f568d5b27bee06c2b8cbed9c954597c2
---
M src/kudu/tablet/ops/op_driver.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/16310/1
--
To view, visit http://gerrit.cloudera.org:8080/16310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b3ffe76f568d5b27bee06c2b8cbed9c954597c2
Gerrit-Change-Number: 16310
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tablet] acquire a lock for DCHECK() only in debug build
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16310 )
Change subject: [tablet] acquire a lock for DCHECK() only in debug build
......................................................................
Patch Set 1: Code-Review+2
Nice find
--
To view, visit http://gerrit.cloudera.org:8080/16310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3ffe76f568d5b27bee06c2b8cbed9c954597c2
Gerrit-Change-Number: 16310
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Aug 2020 23:31:09 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] acquire a lock for DCHECK() only in debug build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16310 )
Change subject: [tablet] acquire a lock for DCHECK() only in debug build
......................................................................
[tablet] acquire a lock for DCHECK() only in debug build
Change-Id: I5b3ffe76f568d5b27bee06c2b8cbed9c954597c2
Reviewed-on: http://gerrit.cloudera.org:8080/16310
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tablet/ops/op_driver.cc
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b3ffe76f568d5b27bee06c2b8cbed9c954597c2
Gerrit-Change-Number: 16310
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] acquire a lock for DCHECK() only in debug build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tablet] acquire a lock for DCHECK() only in debug build
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5b3ffe76f568d5b27bee06c2b8cbed9c954597c2
Gerrit-Change-Number: 16310
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] acquire a lock for DCHECK() only in debug build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16310 )
Change subject: [tablet] acquire a lock for DCHECK() only in debug build
......................................................................
Patch Set 1: Verified+1
Unrelated test failure in TabletServerDiskError/TabletServerDiskErrorITest.TestFailDuringScanWorkload/0 (TSAN build)
--
To view, visit http://gerrit.cloudera.org:8080/16310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3ffe76f568d5b27bee06c2b8cbed9c954597c2
Gerrit-Change-Number: 16310
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Aug 2020 23:28:07 +0000
Gerrit-HasComments: No