You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Fredrik Hedberg (JIRA)" <ji...@apache.org> on 2009/02/08 00:52:59 UTC
[jira] Created: (THRIFT-323) TJSONProtocol
TJSONProtocol
-------------
Key: THRIFT-323
URL: https://issues.apache.org/jira/browse/THRIFT-323
Project: Thrift
Issue Type: New Feature
Components: Library (C#)
Reporter: Fredrik Hedberg
Priority: Minor
TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-323) TJSONProtocol
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695489#action_12695489 ]
Michael Greene commented on THRIFT-323:
---------------------------------------
I would have liked to hear from Fredrik that the new patch works for him. Otherwise, there's no tests, and nobody's using it -- so I don't know what to tell a community member in the future when it doesn't work for them.
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Fredrik Hedberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fredrik Hedberg updated THRIFT-323:
-----------------------------------
Attachment: thrift-csharp-json-2.diff
Removed an unrelated artifact from the patch.
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json-2.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Fredrik Hedberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fredrik Hedberg updated THRIFT-323:
-----------------------------------
Attachment: thrift-csharp-json-3.diff
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json-3.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Clark updated THRIFT-323:
-------------------------------
Fix Version/s: 0.2
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated THRIFT-323:
----------------------------------
Attachment: thrift-csharp-json-4.diff
I don't need this myself, but it's a good feature to have for the library. Given Chad's comments, here is a patch that integrates my comments with the existing code.
Revisions to Fredrik's patch:
* Tabs/spaces converted to match the rest of the code
* Method comments use <summary> tags for IntelliSense
* ASF headers
* Files added to the csproj in addition to the Makefile
It builds? Would be great to have tests still, but if it matches the Java code it most likely works.
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Fredrik Hedberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fredrik Hedberg updated THRIFT-323:
-----------------------------------
Attachment: (was: thrift-csharp-json-2.diff)
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json-3.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-323) TJSONProtocol
Posted by "Chad Walters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688519#action_12688519 ]
Chad Walters commented on THRIFT-323:
-------------------------------------
Not sure. I looked the code over and it seems like a pretty direct translation of my original Java implementation so it seems just great to me! Of course, I don't actually know any C# so I could be missing something.
WRT Michael's comments above:
-- I looked a little at the Base64 conversion methods in System.Convert and the methods there are not suitable for this usage because they don't operate from byte[] to byte[]. Unless there are other standard Base64 methods in C# that I couldn't turn up with some basic web searches, I think Fredrik's port of my Java Base64Utils is the right way to go.
-- I am not sure what is being done with tabs versus spaces by convention in Thrift. I thought I saw an earlier post where David was converting other C# patches to use tabs, so maybe he can do the same here.
-- The headers in the patch have not yet been updated to remove the author tags and put in the ASF header.
So, modulo the tabs/spaces issue and the header, I think it is good to go. Someone want to revise the patch with those fixups?
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json-3.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-323:
---------------------------------
Fix Version/s: (was: 0.5)
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: C# - Library
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-323) TJSONProtocol
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695117#action_12695117 ]
Bryan Duxbury commented on THRIFT-323:
--------------------------------------
Are we waiting on the final word for this patch? I don't see any +1s , and if we want to get this committed to 0.1 you have like 5 days.
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-323) TJSONProtocol
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671872#action_12671872 ]
Michael Greene commented on THRIFT-323:
---------------------------------------
I haven't tested this out yet, but a few things to note:
* .NET already includes a Base64 codec -- did you try using this?
* The rest of the C# libraries use tabs over spaces. We should continue that way for consistency, although at some point I'd like to see it all converted to spaces.
* We're not doing the Author thing anymore (although everyone is thankful for your contributions, of course) - please use the ASF header in all the files.
Excepting the Base64 issue, those are mainly finicky things -- the code looks good, and I'm looking forward to testing it out. Are there any tests you can add?
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json-3.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-323) TJSONProtocol
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688504#action_12688504 ]
Bryan Duxbury commented on THRIFT-323:
--------------------------------------
What's holding this patch up?
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json-3.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated THRIFT-323:
----------------------------------
Fix Version/s: (was: 0.1)
0.2
I agree. I am marking this for 0.2 until someone chimes in that it is working for them, since we want to get a release out imminently.
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-323:
-------------------------------
Attachment: THRIFT-323_csharp_JSON.v5.patch
updated patch is here: [^THRIFT-323_csharp_JSON.v5.patch]
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: C# - Library
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: THRIFT-323_csharp_JSON.v5.patch, thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Clark updated THRIFT-323:
-------------------------------
Fix Version/s: (was: 0.2)
0.1
Feel like this should go in to 0.1 as long as we're close to a patch people are satisfied with.
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-323:
---------------------------------
Fix Version/s: 0.5
(was: 0.4)
Still awaiting a review and a sold +1 vote.
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Fix For: 0.5
>
> Attachments: thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-323:
---------------------------------
Patch Info: (was: [Patch Available])
This patch doesn't apply cleanly.
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: C# - Library
> Reporter: Fredrik Hedberg
> Priority: Minor
> Fix For: 0.5
>
> Attachments: thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Fredrik Hedberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fredrik Hedberg updated THRIFT-323:
-----------------------------------
Attachment: (was: thrift-csharp-json.diff)
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json-2.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-323) TJSONProtocol
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-323.
--------------------------------
Assignee: Roger Meier
Fix Version/s: 0.5
Resolution: Fixed
OK, I just committed this. Thanks for the patch, Roger!
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: C# - Library
> Reporter: Fredrik Hedberg
> Assignee: Roger Meier
> Priority: Minor
> Fix For: 0.5
>
> Attachments: THRIFT-323_csharp_JSON.v5.patch, thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-323) TJSONProtocol
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695504#action_12695504 ]
Bryan Duxbury commented on THRIFT-323:
--------------------------------------
If there are no reviews and no users, I'm not really eager to try and get this committed. I certainly not going to block the 0.1 release on this issue.
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-csharp-json-3.diff, thrift-csharp-json-4.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-323) TJSONProtocol
Posted by "Fredrik Hedberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fredrik Hedberg updated THRIFT-323:
-----------------------------------
Attachment: thrift-csharp-json.diff
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.