You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/03/03 01:15:15 UTC
[kudu-CR](branch-1.6.x) Optionally advance safe time with non-write operations
Hello David Ribeiro Alves, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9481
to review the following change.
Change subject: Optionally advance safe time with non-write operations
......................................................................
Optionally advance safe time with non-write operations
We currently have a problem with safe time advancement when
there are no write messages in the WAL. Because of KUDU-2233,
NO_OP and CHANGE_CONFIG messages are not guaranteed to have
monotonic timestamps, which forced us to ignore them in the
past. This can cause compactions to execute with a timestamp
that is in the beginning of time, causing corruption or crashes.
This patch enables us to advance safe time for all messages
if a flag a set.
Once KUDU-2233 is solved we can flip the flag or remove it
altogether.
Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Reviewed-on: http://gerrit.cloudera.org:8080/9396
Tested-by: David Ribeiro Alves <da...@gmail.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
(cherry picked from commit 611627f2c2e1137f50373954090fa9f7a76badef)
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/9481/1
--
To view, visit http://gerrit.cloudera.org:8080/9481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9481
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.6.x) Optionally advance safe time with non-write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9481 )
Change subject: Optionally advance safe time with non-write operations
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9481
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 03 Mar 2018 04:04:25 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) Optionally advance safe time with non-write operations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9481 )
Change subject: Optionally advance safe time with non-write operations
......................................................................
Patch Set 1: Verified+1
Unrelated flake due to unsyncnronizeed clock:
Bad status: Service unavailable: Couldn't start the single master: Couldn't start master: Cannot initialize clock: Error reading clock. Clock considered unsynchronized
--
To view, visit http://gerrit.cloudera.org:8080/9481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9481
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 03 Mar 2018 06:20:50 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) Optionally advance safe time with non-write operations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9481 )
Change subject: Optionally advance safe time with non-write operations
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9481
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.6.x) Optionally advance safe time with non-write operations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9481 )
Change subject: Optionally advance safe time with non-write operations
......................................................................
Optionally advance safe time with non-write operations
We currently have a problem with safe time advancement when
there are no write messages in the WAL. Because of KUDU-2233,
NO_OP and CHANGE_CONFIG messages are not guaranteed to have
monotonic timestamps, which forced us to ignore them in the
past. This can cause compactions to execute with a timestamp
that is in the beginning of time, causing corruption or crashes.
This patch enables us to advance safe time for all messages
if a flag a set.
Once KUDU-2233 is solved we can flip the flag or remove it
altogether.
Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Reviewed-on: http://gerrit.cloudera.org:8080/9396
Tested-by: David Ribeiro Alves <da...@gmail.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
(cherry picked from commit 611627f2c2e1137f50373954090fa9f7a76badef)
Reviewed-on: http://gerrit.cloudera.org:8080/9481
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 12 insertions(+), 6 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9481
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>