[GitHub] [dolphinscheduler] Tianqi-Dotes commented on a diff in pull request #12276: [FIX][DAO-12277] change t_ds_fav_task column task_name to task_type and related code

[GitBox <gi...@apache.org>]

Tianqi-Dotes commented on code in PR #12276:
URL: https://github.com/apache/dolphinscheduler/pull/12276#discussion_r991172292


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/FavTaskController.java:
##########
@@ -84,8 +84,8 @@ public Result listTaskType(@ApiIgnore @RequestAttribute(value = Constants.SESSIO
     @ApiException(DELETE_TASK_TYPE_ERROR)
     @AccessLogAnnotation(ignoreRequestArgs = "loginUser")
     public Result deleteFavTask(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
-                                @PathVariable("taskName") String taskName) {
-        boolean b = favTaskService.deleteFavTask(loginUser, taskName);
+                                @PathVariable("taskName") String taskType) {

Review Comment:
   emmm..i'm trying to use @TableField avoid this, if change need to change frontend. what's your opinion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org