You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/27 11:58:35 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
tillrohrmann opened a new pull request #18534:
URL: https://github.com/apache/flink/pull/18534
## What is the purpose of the change
The TaskManager session id allows to distinguish between duplicate registration attempts
and a new TaskManager instance that has an old ResourceID.
Signed-off-by: slinkydeveloper <fr...@gmail.com>
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18534:
URL: https://github.com/apache/flink/pull/18534#discussion_r793740065
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterExecutionDeploymentReconciliationTest.java
##########
@@ -270,9 +271,11 @@ private void registerTaskExecutorAndOfferSlots(
throws ExecutionException, InterruptedException {
jobMasterGateway
.registerTaskManager(
- taskExecutorGateway.getAddress(),
- taskManagerLocation,
jobId,
+ TaskManagerRegistrationInformation.create(
+ taskExecutorGateway.getAddress(),
+ taskManagerLocation,
+ TestingUtils.zeroUUID()),
Review comment:
I'm wondering whether this util gives us anything compared to `UUID.randomUUID();` We aren't saving lines, and if this is re-used incorrectly we can easily have 2 TMs with the same session ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #18534:
URL: https://github.com/apache/flink/pull/18534#discussion_r793771436
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterExecutionDeploymentReconciliationTest.java
##########
@@ -270,9 +271,11 @@ private void registerTaskExecutorAndOfferSlots(
throws ExecutionException, InterruptedException {
jobMasterGateway
.registerTaskManager(
- taskExecutorGateway.getAddress(),
- taskManagerLocation,
jobId,
+ TaskManagerRegistrationInformation.create(
+ taskExecutorGateway.getAddress(),
+ taskManagerLocation,
+ TestingUtils.zeroUUID()),
Review comment:
Do you think that this can happen given that the method is part of `TestingUtils` which should not be in the scope for production code? But I do agree that we could also simply use `UUID.randomUUID()` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #18534:
URL: https://github.com/apache/flink/pull/18534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18534:
URL: https://github.com/apache/flink/pull/18534#issuecomment-1023139073
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30303",
"triggerID" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a9ef19365fe5621b2f0a6126a31505624486c35 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30303)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18534:
URL: https://github.com/apache/flink/pull/18534#issuecomment-1023139073
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a9ef19365fe5621b2f0a6126a31505624486c35 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #18534:
URL: https://github.com/apache/flink/pull/18534#issuecomment-1023985257
Thanks for the review @zentol. Merging this PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18534:
URL: https://github.com/apache/flink/pull/18534#issuecomment-1023137086
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1a9ef19365fe5621b2f0a6126a31505624486c35 (Thu Jan 27 12:03:06 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18534:
URL: https://github.com/apache/flink/pull/18534#issuecomment-1023139073
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30303",
"triggerID" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"triggerType" : "PUSH"
}, {
"hash" : "b916ea1e46d6aced448bac2919ebcb9b1c678856",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30328",
"triggerID" : "b916ea1e46d6aced448bac2919ebcb9b1c678856",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a9ef19365fe5621b2f0a6126a31505624486c35 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30303)
* b916ea1e46d6aced448bac2919ebcb9b1c678856 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30328)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18534:
URL: https://github.com/apache/flink/pull/18534#discussion_r794288479
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterExecutionDeploymentReconciliationTest.java
##########
@@ -270,9 +271,11 @@ private void registerTaskExecutorAndOfferSlots(
throws ExecutionException, InterruptedException {
jobMasterGateway
.registerTaskManager(
- taskExecutorGateway.getAddress(),
- taskManagerLocation,
jobId,
+ TaskManagerRegistrationInformation.create(
+ taskExecutorGateway.getAddress(),
+ taskManagerLocation,
+ TestingUtils.zeroUUID()),
Review comment:
Oh it can't happen in production, but during tests :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18534:
URL: https://github.com/apache/flink/pull/18534#issuecomment-1023139073
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30303",
"triggerID" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"triggerType" : "PUSH"
}, {
"hash" : "b916ea1e46d6aced448bac2919ebcb9b1c678856",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30328",
"triggerID" : "b916ea1e46d6aced448bac2919ebcb9b1c678856",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b916ea1e46d6aced448bac2919ebcb9b1c678856 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30328)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18534:
URL: https://github.com/apache/flink/pull/18534#issuecomment-1023139073
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30303",
"triggerID" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"triggerType" : "PUSH"
}, {
"hash" : "b916ea1e46d6aced448bac2919ebcb9b1c678856",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b916ea1e46d6aced448bac2919ebcb9b1c678856",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a9ef19365fe5621b2f0a6126a31505624486c35 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30303)
* b916ea1e46d6aced448bac2919ebcb9b1c678856 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18534:
URL: https://github.com/apache/flink/pull/18534#issuecomment-1023139073
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30303",
"triggerID" : "1a9ef19365fe5621b2f0a6126a31505624486c35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a9ef19365fe5621b2f0a6126a31505624486c35 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30303)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org