[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1193: [#1028] improvement(operator): Make rss-env.sh and HadoopConfig configurable via ConfigMap

["jerqi (via GitHub)" <gi...@apache.org>]

jerqi commented on code in PR #1193:
URL: https://github.com/apache/incubator-uniffle/pull/1193#discussion_r1324098100


##########
deploy/kubernetes/operator/examples/configuration.yaml:
##########
@@ -72,4 +73,30 @@ data:
     rss.server.read.buffer.capacity 5g
     rss.server.shuffle.expired.timeout.ms 120000
     rss.server.write.retry.max 2
-    rss.storage.type MEMORY_LOCALFILE
\ No newline at end of file
+    rss.storage.type MEMORY_LOCALFILE
+    # rss.security.hadoop.kerberos.keytab.file /data/rssadmin/hadoop/conf/uniffle.keytab
+  dynamic_client.conf: |-
+    # MEMORY_LOCALFILE_HDFS is recommended for production environment
+    rss.storage.type MEMORY_LOCALFILE_HDFS
+    # multiple remote storages are supported, and client will get assignment from coordinator
+    rss.coordinator.remote.storage.path hdfs://cluster1/path,hdfs://cluster2/path
+    rss.writer.require.memory.retryMax 1200
+    rss.client.retry.max 50
+    rss.writer.send.check.timeout 600000
+    rss.client.read.buffer.size 14m
+  rss-env.sh: |-
+    set -o pipefail
+    set -o nounset
+    set -o errexit
+    HADOOP_HOME="/data/rssadmin/hadoop"
+    RUNNER="${JAVA_HOME}/bin/java"
+    JPS="${JAVA_HOME}/bin/jps"
+    
+    # HADOOP_CONF_DIR, Hadoop configuration directory (Default: ${HADOOP_HOME}/etc/hadoop)
+    HADOOP_CONF_DIR="/data/rssadmin/hadoop/conf"

Review Comment:
   Because we install the package of  hadoop in the  `/data/rssadmin/hadoop` in our Dockerfile.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org