You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/06/18 04:20:21 UTC
Review Request 35590: LENS-477 - Lens service health status
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Diffs
-----
lens-server/pom.xml bb12e00
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesMetastoreCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesQueryApiCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
Diff: https://reviews.apache.org/r/35590/diff/
Testing
-------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
> On June 18, 2015, 7:29 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java, line 42
> > <https://reviews.apache.org/r/35590/diff/1/?file=986668#file986668line42>
> >
> > Do we need to make a REST call from the server itself? Doesn't seem right.
>
> Yash Sharma wrote:
> Seemed like the neatest way to check if endpoints are up. Do you have anything in mind ?
>
> Rajat Khandelwal wrote:
> Oh. I didn't know we were checking whether the endpoints are up. :)
>
> Amareshwari Sriramadasu wrote:
> I dont think we want to check end points are up from health status.
>
> We should add an api in LensService getHealthStatus() where each service will return its health. For ex: Metastore service should check whether it is able to reach underlying metastore, similarly query service could give status of each driver.
@amareshwari: Roger that. Let me start working on it.
@prongs: My misinterpretation it was :)
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review88346
-----------------------------------------------------------
On June 18, 2015, 2:23 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 2:23 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesMetastoreCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesQueryApiCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On June 18, 2015, 7:29 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java, line 42
> > <https://reviews.apache.org/r/35590/diff/1/?file=986668#file986668line42>
> >
> > Do we need to make a REST call from the server itself? Doesn't seem right.
>
> Yash Sharma wrote:
> Seemed like the neatest way to check if endpoints are up. Do you have anything in mind ?
>
> Rajat Khandelwal wrote:
> Oh. I didn't know we were checking whether the endpoints are up. :)
I dont think we want to check end points are up from health status.
We should add an api in LensService getHealthStatus() where each service will return its health. For ex: Metastore service should check whether it is able to reach underlying metastore, similarly query service could give status of each driver.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review88346
-----------------------------------------------------------
On June 18, 2015, 2:23 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 2:23 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesMetastoreCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesQueryApiCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
> On June 18, 2015, 7:29 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java, line 42
> > <https://reviews.apache.org/r/35590/diff/1/?file=986668#file986668line42>
> >
> > Do we need to make a REST call from the server itself? Doesn't seem right.
Seemed like the neatest way to check if endpoints are up. Do you have anything in mind ?
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review88346
-----------------------------------------------------------
On June 18, 2015, 2:23 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 2:23 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesMetastoreCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesQueryApiCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 18, 2015, 12:59 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java, line 42
> > <https://reviews.apache.org/r/35590/diff/1/?file=986668#file986668line42>
> >
> > Do we need to make a REST call from the server itself? Doesn't seem right.
>
> Yash Sharma wrote:
> Seemed like the neatest way to check if endpoints are up. Do you have anything in mind ?
Oh. I didn't know we were checking whether the endpoints are up. :)
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review88346
-----------------------------------------------------------
On June 18, 2015, 7:53 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 7:53 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesMetastoreCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesQueryApiCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review88346
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java (line 42)
<https://reviews.apache.org/r/35590/#comment140826>
Do we need to make a REST call from the server itself? Doesn't seem right.
- Rajat Khandelwal
On June 18, 2015, 7:53 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 7:53 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesMetastoreCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesQueryApiCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
> On July 3, 2015, 9:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/pom.xml, line 245
> > <https://reviews.apache.org/r/35590/diff/2/?file=989062#file989062line245>
> >
> > Is this dependency required?
This was required for querying the rest endpoint. Have removed endpoint check and the dependency now.
> On July 3, 2015, 9:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensService.java, line 431
> > <https://reviews.apache.org/r/35590/diff/2/?file=989063#file989063line431>
> >
> > Instead of simple boolean status of healthy or not, let it give isHealthy or not, along with details of what is not healthy.
> >
> > Something like
> > HealthStatus {
> > boolean healthy;
> > String details;
> > }
+1. Implemented.
> On July 3, 2015, 9:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensAdminStatusCheck.java, line 41
> > <https://reviews.apache.org/r/35590/diff/2/?file=989064#file989064line41>
> >
> > This doesnt seem reasonable to be here - hitting the same server through end point.
Removed endpoints hits now.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review90328
-----------------------------------------------------------
On July 4, 2015, 8:31 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 4, 2015, 8:31 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthStatus.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 07e20dc
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b262
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 36adee0
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> {"metastore":{"healthy":true},"query":{"healthy":true},"quota":{"healthy":true},"scheduler":{"healthy":true},"session":{"healthy":true}}
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.406 s]
> [INFO] Lens ............................................... SUCCESS [ 3.076 s]
> [INFO] Lens API ........................................... SUCCESS [ 21.916 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 24.478 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:27 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.254 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.945 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:42 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 39.914 s]
> [INFO] Lens Server ........................................ SUCCESS [05:47 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.465 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:17 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.659 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.244 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:24 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.815 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.904 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:06 min
> [INFO] Finished at: 2015-07-04T13:54:16+05:30
> [INFO] Final Memory: 125M/400M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review90328
-----------------------------------------------------------
lens-server/pom.xml (line 245)
<https://reviews.apache.org/r/35590/#comment143342>
Is this dependency required?
lens-server/src/main/java/org/apache/lens/server/LensService.java (line 431)
<https://reviews.apache.org/r/35590/#comment143343>
Instead of simple boolean status of healthy or not, let it give isHealthy or not, along with details of what is not healthy.
Something like
HealthStatus {
boolean healthy;
String details;
}
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensAdminStatusCheck.java (line 41)
<https://reviews.apache.org/r/35590/#comment143344>
This doesnt seem reasonable to be here - hitting the same server through end point.
- Amareshwari Sriramadasu
On June 21, 2015, 3:45 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated June 21, 2015, 3:45 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensAdminStatusCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensMetastoreCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensQueryApiCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 07e20dc
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8a1b7c8
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java fa061ec
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
> On July 17, 2015, 4:41 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java, lines 29-38
> > <https://reviews.apache.org/r/35590/diff/4/?file=1013139#file1013139line29>
> >
> > I see all HealthCheck are doing the same code. Can we create LensServiceHealthCheck super class and pass Service instance from all subclasses?
>
> Yash Sharma wrote:
> In our case all the services do not share a common superclass. Have moved the code to utility class for reuse. Extending from superclass and HealthCheck would also complicate design. Let me know if new changes looks good.
>
> Amareshwari Sriramadasu wrote:
> Looks fine.
Great.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review92023
-----------------------------------------------------------
On July 22, 2015, 6 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 6 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthCheckable.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/LensService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f82
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 72fe455
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/LensServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensServices.java fe58e96
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 2455232
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e5fcd5
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.070 s]
> [INFO] Lens ............................................... SUCCESS [ 5.328 s]
> [INFO] Lens API ........................................... SUCCESS [ 21.978 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 26.296 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:52 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.124 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.063 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:39 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.737 s]
> [INFO] Lens Server ........................................ SUCCESS [05:30 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.113 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:45 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 13.261 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.223 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:25 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.725 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.116 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:45 min
> [INFO] Finished at: 2015-07-22T23:18:19+05:30
> [INFO] Final Memory: 131M/369M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 17, 2015, 4:41 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java, lines 29-38
> > <https://reviews.apache.org/r/35590/diff/4/?file=1013139#file1013139line29>
> >
> > I see all HealthCheck are doing the same code. Can we create LensServiceHealthCheck super class and pass Service instance from all subclasses?
>
> Yash Sharma wrote:
> In our case all the services do not share a common superclass. Have moved the code to utility class for reuse. Extending from superclass and HealthCheck would also complicate design. Let me know if new changes looks good.
Looks fine.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review92023
-----------------------------------------------------------
On July 17, 2015, 6:59 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 17, 2015, 6:59 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.821 s]
> [INFO] Lens ............................................... SUCCESS [ 2.711 s]
> [INFO] Lens API ........................................... SUCCESS [ 18.261 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 19.128 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:32 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 18.811 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.330 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:28 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.381 s]
> [INFO] Lens Server ........................................ SUCCESS [04:58 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.044 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:06 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.153 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.328 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.598 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.416 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:25 min
> [INFO] Finished at: 2015-07-18T00:11:59+05:30
> [INFO] Final Memory: 130M/402M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
> On July 17, 2015, 4:41 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java, lines 29-38
> > <https://reviews.apache.org/r/35590/diff/4/?file=1013139#file1013139line29>
> >
> > I see all HealthCheck are doing the same code. Can we create LensServiceHealthCheck super class and pass Service instance from all subclasses?
In our case all the services do not share a common superclass. Have moved the code to utility class for reuse. Extending from superclass and HealthCheck would also complicate design. Let me know if new changes looks good.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review92023
-----------------------------------------------------------
On July 17, 2015, 6:58 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 17, 2015, 6:58 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.589 s]
> [INFO] Lens ............................................... SUCCESS [ 3.790 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.511 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.891 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:41 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.744 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 17.011 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:40 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.243 s]
> [INFO] Lens Server ........................................ SUCCESS [05:18 min]
> [INFO] Lens client ........................................ SUCCESS [ 35.673 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:08 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.318 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.788 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.502 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.451 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:37 min
> [INFO] Finished at: 2015-07-16T11:36:36+05:30
> [INFO] Final Memory: 127M/356M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review92023
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java (lines 29 - 38)
<https://reviews.apache.org/r/35590/#comment145883>
I see all HealthCheck are doing the same code. Can we create LensServiceHealthCheck super class and pass Service instance from all subclasses?
- Amareshwari Sriramadasu
On July 16, 2015, 6:18 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 16, 2015, 6:18 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java a778a1f
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.589 s]
> [INFO] Lens ............................................... SUCCESS [ 3.790 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.511 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.891 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:41 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.744 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 17.011 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:40 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.243 s]
> [INFO] Lens Server ........................................ SUCCESS [05:18 min]
> [INFO] Lens client ........................................ SUCCESS [ 35.673 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:08 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.318 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.788 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.502 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.451 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:37 min
> [INFO] Finished at: 2015-07-16T11:36:36+05:30
> [INFO] Final Memory: 127M/356M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 20, 2015, 8:41 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java, line 197
> > <https://reviews.apache.org/r/35590/diff/6/?file=1015968#file1015968line197>
> >
> > The same signature of the function is being added to all services. We can probably extract out an interface and extend the services from it. Then we'll not need health check classes for each service.
> >
> > The interface can be called `HealthCheckable`. This would be a short and sweet solution.
> >
> >
> > However, we can take this as an opportunity to refactor and make a `LensService` interface. The current `LensService` class would either be called `LensServiceImpl` or its methods will move to someplace else causing us to use composition over inheritence. Of course, if the change is too big, we can leave the latter part and only do the renaming.
+1 for HealthCheckable interface and services implementing it.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review92233
-----------------------------------------------------------
On July 19, 2015, 8:54 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 8:54 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 s]
> [INFO] Lens ............................................... SUCCESS [ 3.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.033 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.663 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:51 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.836 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.746 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.651 s]
> [INFO] Lens Server ........................................ SUCCESS [05:55 min]
> [INFO] Lens client ........................................ SUCCESS [ 38.404 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:13 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 12.174 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.385 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:22 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.994 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.776 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:24 min
> [INFO] Finished at: 2015-07-19T13:30:22+05:30
> [INFO] Final Memory: 130M/408M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review92233
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java (line 197)
<https://reviews.apache.org/r/35590/#comment146284>
The same signature of the function is being added to all services. We can probably extract out an interface and extend the services from it. Then we'll not need health check classes for each service.
The interface can be called `HealthCheckable`. This would be a short and sweet solution.
However, we can take this as an opportunity to refactor and make a `LensService` interface. The current `LensService` class would either be called `LensServiceImpl` or its methods will move to someplace else causing us to use composition over inheritence. Of course, if the change is too big, we can leave the latter part and only do the renaming.
- Rajat Khandelwal
On July 19, 2015, 2:24 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 2:24 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 s]
> [INFO] Lens ............................................... SUCCESS [ 3.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.033 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.663 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:51 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.836 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.746 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.651 s]
> [INFO] Lens Server ........................................ SUCCESS [05:55 min]
> [INFO] Lens client ........................................ SUCCESS [ 38.404 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:13 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 12.174 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.385 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:22 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.994 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.776 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:24 min
> [INFO] Finished at: 2015-07-19T13:30:22+05:30
> [INFO] Final Memory: 130M/408M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review92034
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java (line 26)
<https://reviews.apache.org/r/35590/#comment145915>
If no setters, we can make these final and replace the constructor with `@RequiredArgsConstructor`
- Rajat Khandelwal
On July 19, 2015, 2:24 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 2:24 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 s]
> [INFO] Lens ............................................... SUCCESS [ 3.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.033 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.663 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:51 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.836 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.746 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.651 s]
> [INFO] Lens Server ........................................ SUCCESS [05:55 min]
> [INFO] Lens client ........................................ SUCCESS [ 38.404 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:13 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 12.174 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.385 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:22 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.994 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.776 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:24 min
> [INFO] Finished at: 2015-07-19T13:30:22+05:30
> [INFO] Final Memory: 130M/408M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated July 25, 2015, 1:30 p.m.)
Review request for lens.
Changes
-------
Implemented review comments.
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthCheckable.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthStatus.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f82
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 72fe455
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 2c6f912
lens-server/src/main/java/org/apache/lens/server/LensService.java 0e564a9
lens-server/src/main/java/org/apache/lens/server/LensServices.java 1bcc5944
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 2455232
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 5e0f24a
lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 0635e95
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 697e867
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
src/site/apt/user/cli.apt 63f2b3f
Diff: https://reviews.apache.org/r/35590/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.036 s]
[INFO] Lens ............................................... SUCCESS [ 2.895 s]
[INFO] Lens API ........................................... SUCCESS [ 23.806 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 24.685 s]
[INFO] Lens Cube .......................................... SUCCESS [03:53 min]
[INFO] Lens DB storage .................................... SUCCESS [ 18.954 s]
[INFO] Lens Query Library ................................. SUCCESS [ 16.349 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 41.719 s]
[INFO] Lens Server ........................................ SUCCESS [05:11 min]
[INFO] Lens client ........................................ SUCCESS [ 35.974 s]
[INFO] Lens CLI ........................................... SUCCESS [02:06 min]
[INFO] Lens Examples ...................................... SUCCESS [ 8.917 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.886 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:42 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.861 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.294 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:53 min
[INFO] Finished at: 2015-07-25T18:55:48+05:30
[INFO] Final Memory: 132M/415M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review92871
-----------------------------------------------------------
Ship it!
Other changes look fine.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (lines 2499 - 2505)
<https://reviews.apache.org/r/35590/#comment147117>
Seems a merge issue. This was moved to UtilityMethods.
- Amareshwari Sriramadasu
On July 23, 2015, 5:40 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 5:40 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthCheckable.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f82
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 72fe455
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 2c6f912
> lens-server/src/main/java/org/apache/lens/server/LensService.java 0e564a9
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 1bcc5944
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 2455232
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 5e0f24a
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 0635e95
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 697e867
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.755 s]
> [INFO] Lens ............................................... SUCCESS [ 5.646 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.286 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.510 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:34 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.073 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.134 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:29 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.798 s]
> [INFO] Lens Server ........................................ SUCCESS [05:46 min]
> [INFO] Lens client ........................................ SUCCESS [ 39.626 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.641 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.716 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.037 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.356 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:34 min
> [INFO] Finished at: 2015-07-23T22:56:31+05:30
> [INFO] Final Memory: 131M/390M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated July 23, 2015, 5:40 p.m.)
Review request for lens.
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthCheckable.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthStatus.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f82
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 72fe455
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 2c6f912
lens-server/src/main/java/org/apache/lens/server/LensService.java 0e564a9
lens-server/src/main/java/org/apache/lens/server/LensServices.java 1bcc5944
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 2455232
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 5e0f24a
lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 0635e95
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 697e867
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
src/site/apt/user/cli.apt 63f2b3f
Diff: https://reviews.apache.org/r/35590/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.755 s]
[INFO] Lens ............................................... SUCCESS [ 5.646 s]
[INFO] Lens API ........................................... SUCCESS [ 22.286 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 20.510 s]
[INFO] Lens Cube .......................................... SUCCESS [03:34 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.073 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.134 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:29 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.798 s]
[INFO] Lens Server ........................................ SUCCESS [05:46 min]
[INFO] Lens client ........................................ SUCCESS [ 39.626 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.641 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.716 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.037 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.356 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:34 min
[INFO] Finished at: 2015-07-23T22:56:31+05:30
[INFO] Final Memory: 131M/390M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated July 23, 2015, 4:50 p.m.)
Review request for lens.
Changes
-------
Implemented review comments.
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthCheckable.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthStatus.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f82
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 72fe455
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 2c6f912
lens-server/src/main/java/org/apache/lens/server/LensService.java 0e564a9
lens-server/src/main/java/org/apache/lens/server/LensServices.java 1bcc5944
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 2455232
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 5e0f24a
lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 0635e95
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 697e867
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
src/site/apt/user/cli.apt 63f2b3f
Diff: https://reviews.apache.org/r/35590/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.070 s]
[INFO] Lens ............................................... SUCCESS [ 5.328 s]
[INFO] Lens API ........................................... SUCCESS [ 21.978 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 26.296 s]
[INFO] Lens Cube .......................................... SUCCESS [03:52 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.124 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.063 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:39 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.737 s]
[INFO] Lens Server ........................................ SUCCESS [05:30 min]
[INFO] Lens client ........................................ SUCCESS [ 45.113 s]
[INFO] Lens CLI ........................................... SUCCESS [02:45 min]
[INFO] Lens Examples ...................................... SUCCESS [ 13.261 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.223 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:25 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.725 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.116 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:45 min
[INFO] Finished at: 2015-07-22T23:18:19+05:30
[INFO] Final Memory: 131M/369M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
> On July 23, 2015, 5:13 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensServices.java, line 87
> > <https://reviews.apache.org/r/35590/diff/7/?file=1018892#file1018892line87>
> >
> > Shall we call LensServiceImpl as BaseLensService - as its not actually implementing much - providing a base class for implementations?
Sounds good. Renamed.
> On July 23, 2015, 5:13 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/health/HealthCheckable.java, line 19
> > <https://reviews.apache.org/r/35590/diff/7/?file=1018883#file1018883line19>
> >
> > Move this to lens-server-api
Done.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review92722
-----------------------------------------------------------
On July 23, 2015, 4:50 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 4:50 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthCheckable.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f82
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 72fe455
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 2c6f912
> lens-server/src/main/java/org/apache/lens/server/LensService.java 0e564a9
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 1bcc5944
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 2455232
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 5e0f24a
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 0635e95
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 697e867
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.070 s]
> [INFO] Lens ............................................... SUCCESS [ 5.328 s]
> [INFO] Lens API ........................................... SUCCESS [ 21.978 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 26.296 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:52 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.124 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.063 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:39 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.737 s]
> [INFO] Lens Server ........................................ SUCCESS [05:30 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.113 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:45 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 13.261 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.223 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:25 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.725 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.116 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:45 min
> [INFO] Finished at: 2015-07-22T23:18:19+05:30
> [INFO] Final Memory: 131M/369M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review92722
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/health/HealthCheckable.java (line 19)
<https://reviews.apache.org/r/35590/#comment146968>
Move this to lens-server-api
lens-server/src/main/java/org/apache/lens/server/LensServices.java (line 87)
<https://reviews.apache.org/r/35590/#comment146969>
Shall we call LensServiceImpl as BaseLensService - as its not actually implementing much - providing a base class for implementations?
- Amareshwari Sriramadasu
On July 22, 2015, 6 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 6 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthCheckable.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/LensService.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f82
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 72fe455
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/LensServiceImpl.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensServices.java fe58e96
> lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 2455232
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e5fcd5
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.070 s]
> [INFO] Lens ............................................... SUCCESS [ 5.328 s]
> [INFO] Lens API ........................................... SUCCESS [ 21.978 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 26.296 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:52 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.124 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.063 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:39 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.737 s]
> [INFO] Lens Server ........................................ SUCCESS [05:30 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.113 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:45 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 13.261 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.223 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:25 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.725 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.116 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:45 min
> [INFO] Finished at: 2015-07-22T23:18:19+05:30
> [INFO] Final Memory: 131M/369M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated July 22, 2015, 6 p.m.)
Review request for lens.
Changes
-------
Implemented review comments.
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/health/HealthCheckable.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/LensService.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f82
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 72fe455
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/LensServiceImpl.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensServices.java fe58e96
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 2455232
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e5fcd5
lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
src/site/apt/user/cli.apt 63f2b3f
Diff: https://reviews.apache.org/r/35590/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.070 s]
[INFO] Lens ............................................... SUCCESS [ 5.328 s]
[INFO] Lens API ........................................... SUCCESS [ 21.978 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 26.296 s]
[INFO] Lens Cube .......................................... SUCCESS [03:52 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.124 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.063 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:39 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.737 s]
[INFO] Lens Server ........................................ SUCCESS [05:30 min]
[INFO] Lens client ........................................ SUCCESS [ 45.113 s]
[INFO] Lens CLI ........................................... SUCCESS [02:45 min]
[INFO] Lens Examples ...................................... SUCCESS [ 13.261 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.223 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:25 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.725 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.116 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:45 min
[INFO] Finished at: 2015-07-22T23:18:19+05:30
[INFO] Final Memory: 131M/369M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated July 19, 2015, 8:54 a.m.)
Review request for lens.
Changes
-------
Implemented new review comments.
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
Diff: https://reviews.apache.org/r/35590/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 s]
[INFO] Lens ............................................... SUCCESS [ 3.994 s]
[INFO] Lens API ........................................... SUCCESS [ 20.033 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.663 s]
[INFO] Lens Cube .......................................... SUCCESS [03:51 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.836 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.746 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.651 s]
[INFO] Lens Server ........................................ SUCCESS [05:55 min]
[INFO] Lens client ........................................ SUCCESS [ 38.404 s]
[INFO] Lens CLI ........................................... SUCCESS [02:13 min]
[INFO] Lens Examples ...................................... SUCCESS [ 12.174 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.385 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:22 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.994 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.776 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:24 min
[INFO] Finished at: 2015-07-19T13:30:22+05:30
[INFO] Final Memory: 130M/408M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated July 17, 2015, 6:59 p.m.)
Review request for lens.
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
Diff: https://reviews.apache.org/r/35590/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.821 s]
[INFO] Lens ............................................... SUCCESS [ 2.711 s]
[INFO] Lens API ........................................... SUCCESS [ 18.261 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 19.128 s]
[INFO] Lens Cube .......................................... SUCCESS [03:32 min]
[INFO] Lens DB storage .................................... SUCCESS [ 18.811 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.330 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:28 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.381 s]
[INFO] Lens Server ........................................ SUCCESS [04:58 min]
[INFO] Lens client ........................................ SUCCESS [ 37.044 s]
[INFO] Lens CLI ........................................... SUCCESS [02:06 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.153 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.328 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:20 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.598 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.416 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:25 min
[INFO] Finished at: 2015-07-18T00:11:59+05:30
[INFO] Final Memory: 130M/402M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated July 17, 2015, 6:58 p.m.)
Review request for lens.
Changes
-------
Implemented new review comments.
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
Diff: https://reviews.apache.org/r/35590/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.589 s]
[INFO] Lens ............................................... SUCCESS [ 3.790 s]
[INFO] Lens API ........................................... SUCCESS [ 20.511 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 20.891 s]
[INFO] Lens Cube .......................................... SUCCESS [03:41 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.744 s]
[INFO] Lens Query Library ................................. SUCCESS [ 17.011 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:40 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.243 s]
[INFO] Lens Server ........................................ SUCCESS [05:18 min]
[INFO] Lens client ........................................ SUCCESS [ 35.673 s]
[INFO] Lens CLI ........................................... SUCCESS [02:08 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.318 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.788 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.502 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.451 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:37 min
[INFO] Finished at: 2015-07-16T11:36:36+05:30
[INFO] Final Memory: 127M/356M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated July 16, 2015, 6:18 a.m.)
Review request for lens.
Changes
-------
Implemented review comments.
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java a778a1f
lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
Diff: https://reviews.apache.org/r/35590/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.589 s]
[INFO] Lens ............................................... SUCCESS [ 3.790 s]
[INFO] Lens API ........................................... SUCCESS [ 20.511 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 20.891 s]
[INFO] Lens Cube .......................................... SUCCESS [03:41 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.744 s]
[INFO] Lens Query Library ................................. SUCCESS [ 17.011 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:40 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.243 s]
[INFO] Lens Server ........................................ SUCCESS [05:18 min]
[INFO] Lens client ........................................ SUCCESS [ 35.673 s]
[INFO] Lens CLI ........................................... SUCCESS [02:08 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.318 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.788 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.502 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.451 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:37 min
[INFO] Finished at: 2015-07-16T11:36:36+05:30
[INFO] Final Memory: 127M/356M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote:
> > Can you add unit tests?
>
> Yash Sharma wrote:
> Added testcase but was stumbling on checking for -ve scenario.
> Wondering what is the best way to kill services-> check health-> bring them back up ?
May be you can add test in TestServerRestart.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review90436
-----------------------------------------------------------
On July 17, 2015, 6:59 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 17, 2015, 6:59 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.821 s]
> [INFO] Lens ............................................... SUCCESS [ 2.711 s]
> [INFO] Lens API ........................................... SUCCESS [ 18.261 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 19.128 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:32 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 18.811 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.330 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:28 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.381 s]
> [INFO] Lens Server ........................................ SUCCESS [04:58 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.044 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:06 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.153 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.328 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:20 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.598 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.416 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:25 min
> [INFO] Finished at: 2015-07-18T00:11:59+05:30
> [INFO] Final Memory: 130M/402M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
> On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote:
> > Can you add unit tests?
Added testcase but was stumbling on checking for -ve scenario.
Wondering what is the best way to kill services-> check health-> bring them back up ?
> On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthStatus.java, line 31
> > <https://reviews.apache.org/r/35590/diff/3/?file=999099#file999099line31>
> >
> > Use lombak Getters instead
+1
> On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, line 1436
> > <https://reviews.apache.org/r/35590/diff/3/?file=999104#file999104line1436>
> >
> > Will this ever return null?
Now check is moved to Catch block directly.
> On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java, line 266
> > <https://reviews.apache.org/r/35590/diff/3/?file=999105#file999105line266>
> >
> > Can we add checks for EventService and MetricsService as well?
Implemented.
> On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 2311
> > <https://reviews.apache.org/r/35590/diff/3/?file=999106#file999106line2311>
> >
> > Can we add one check for estimation threadpool as well?
Implemented.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review90436
-----------------------------------------------------------
On July 16, 2015, 6:18 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 16, 2015, 6:18 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java a778a1f
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.589 s]
> [INFO] Lens ............................................... SUCCESS [ 3.790 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.511 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.891 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:41 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.744 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 17.011 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:40 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.243 s]
> [INFO] Lens Server ........................................ SUCCESS [05:18 min]
> [INFO] Lens client ........................................ SUCCESS [ 35.673 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:08 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.318 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.788 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.502 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.451 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:37 min
> [INFO] Finished at: 2015-07-16T11:36:36+05:30
> [INFO] Final Memory: 127M/356M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
> On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote:
> > Can you add unit tests?
>
> Yash Sharma wrote:
> Added testcase but was stumbling on checking for -ve scenario.
> Wondering what is the best way to kill services-> check health-> bring them back up ?
>
> Amareshwari Sriramadasu wrote:
> May be you can add test in TestServerRestart.
Added. Thanks.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review90436
-----------------------------------------------------------
On July 19, 2015, 8:54 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 8:54 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 74cc00c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71128b7
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java c5e1c14
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 3a8fc95
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 s]
> [INFO] Lens ............................................... SUCCESS [ 3.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.033 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.663 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:51 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.836 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.746 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:44 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.651 s]
> [INFO] Lens Server ........................................ SUCCESS [05:55 min]
> [INFO] Lens client ........................................ SUCCESS [ 38.404 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:13 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 12.174 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.385 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:22 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.994 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.776 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:24 min
> [INFO] Finished at: 2015-07-19T13:30:22+05:30
> [INFO] Final Memory: 130M/408M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/#review90436
-----------------------------------------------------------
Can you add unit tests?
lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthStatus.java (line 31)
<https://reviews.apache.org/r/35590/#comment143478>
Use lombak Getters instead
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 1436)
<https://reviews.apache.org/r/35590/#comment143479>
Will this ever return null?
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java (line 266)
<https://reviews.apache.org/r/35590/#comment143481>
Can we add checks for EventService and MetricsService as well?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 2311)
<https://reviews.apache.org/r/35590/#comment143480>
Can we add one check for estimation threadpool as well?
- Amareshwari Sriramadasu
On July 4, 2015, 8:31 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35590/
> -----------------------------------------------------------
>
> (Updated July 4, 2015, 8:31 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Lens service health status.
>
> https://issues.apache.org/jira/browse/LENS-477
>
> Initial patch for LENS-477.
> We should list all other API/Endpoints etc that should be considered for health checks.
>
> Current checks implemented-
> curl http://localhost:9999/admin/healthcheck
> {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthStatus.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 07e20dc
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b262
> lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 36adee0
>
> Diff: https://reviews.apache.org/r/35590/diff/
>
>
> Testing
> -------
>
> {"metastore":{"healthy":true},"query":{"healthy":true},"quota":{"healthy":true},"scheduler":{"healthy":true},"session":{"healthy":true}}
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.406 s]
> [INFO] Lens ............................................... SUCCESS [ 3.076 s]
> [INFO] Lens API ........................................... SUCCESS [ 21.916 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 24.478 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:27 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.254 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.945 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:42 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 39.914 s]
> [INFO] Lens Server ........................................ SUCCESS [05:47 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.465 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:17 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.659 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.244 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:24 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.815 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.904 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:06 min
> [INFO] Finished at: 2015-07-04T13:54:16+05:30
> [INFO] Final Memory: 125M/400M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated July 4, 2015, 8:31 a.m.)
Review request for lens.
Changes
-------
New review comments and code refactoring.
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthStatus.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 07e20dc
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 39f9f52
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b262
lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 36adee0
Diff: https://reviews.apache.org/r/35590/diff/
Testing (updated)
-------
{"metastore":{"healthy":true},"query":{"healthy":true},"quota":{"healthy":true},"scheduler":{"healthy":true},"session":{"healthy":true}}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.406 s]
[INFO] Lens ............................................... SUCCESS [ 3.076 s]
[INFO] Lens API ........................................... SUCCESS [ 21.916 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 24.478 s]
[INFO] Lens Cube .......................................... SUCCESS [03:27 min]
[INFO] Lens DB storage .................................... SUCCESS [ 21.254 s]
[INFO] Lens Query Library ................................. SUCCESS [ 16.945 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:42 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 39.914 s]
[INFO] Lens Server ........................................ SUCCESS [05:47 min]
[INFO] Lens client ........................................ SUCCESS [ 41.465 s]
[INFO] Lens CLI ........................................... SUCCESS [02:17 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.659 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.244 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:24 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.815 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.904 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:06 min
[INFO] Finished at: 2015-07-04T13:54:16+05:30
[INFO] Final Memory: 125M/400M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated June 21, 2015, 3:45 a.m.)
Review request for lens.
Changes
-------
New checks for LensServices.
Have kept the endpoind check for now. Can be removed if required.
Also let me know if we need any other checks.
Please review.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.546 s]
[INFO] Lens ............................................... SUCCESS [ 4.492 s]
[INFO] Lens API ........................................... SUCCESS [ 23.622 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 26.609 s]
[INFO] Lens Cube .......................................... SUCCESS [03:14 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.053 s]
[INFO] Lens Query Library ................................. SUCCESS [ 16.111 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:36 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.424 s]
[INFO] Lens Server ........................................ SUCCESS [04:56 min]
[INFO] Lens client ........................................ SUCCESS [ 38.366 s]
[INFO] Lens CLI ........................................... SUCCESS [02:07 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.603 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.810 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.896 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.626 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:35 min
[INFO] Finished at: 2015-06-21T01:46:31+05:30
[INFO] Final Memory: 125M/418M
[INFO] ------------------------------------------------------------------------
{"admin-status":{"healthy":true},"lens-services":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Repository: lens
Description
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs (updated)
-----
lens-server/pom.xml bb12e00
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensAdminStatusCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensMetastoreCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensQueryApiCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 07e20dc
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8a1b7c8
lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java 89cfe71
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 32feeb9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java fa061ec
Diff: https://reviews.apache.org/r/35590/diff/
Testing
-------
Thanks,
Yash Sharma
Re: Review Request 35590: LENS-477 - Lens service health status
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35590/
-----------------------------------------------------------
(Updated June 18, 2015, 2:23 a.m.)
Review request for lens.
Repository: lens
Description (updated)
-------
Lens service health status.
https://issues.apache.org/jira/browse/LENS-477
Initial patch for LENS-477.
We should list all other API/Endpoints etc that should be considered for health checks.
Current checks implemented-
curl http://localhost:9999/admin/healthcheck
{"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}}
Diffs
-----
lens-server/pom.xml bb12e00
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesMetastoreCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesQueryApiCheck.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
Diff: https://reviews.apache.org/r/35590/diff/
Testing
-------
Thanks,
Yash Sharma