[jira] [Updated] (HADOOP-10775) Shell operations to fail with meaningful errors on windows if winutils.exe not found

["Steve Loughran (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated HADOOP-10775:
------------------------------------
    Attachment: HADOOP-10775.patch

As well as retaining the original {{WINUTILS}} field, which is null if the field could not be retrieved, I've added two methods {{getWindowsU

# {{getWinutilsPathStrict()}} raises an IOE
# {{getWinutilsPathRTE()}} raises an RTE: I've inserted this where the method calling it doesn't raise an IOE.

Both these will throw an exception which nests the exception caught when trying to set up the path; those also include, on windows a link to a new wiki page.

* The wiki entry is [[https://wiki.apache.org/hadoop/WindowsProblems]]
* It links to a repo where we can collect the windows binaries. Currently [[mine|https://github.com/steveloughran/winutils]]

I've not been through all references to Shell.WINUTILS; the ones where a path is set up but not executed are left alone (e.g. {{Shell.getSetPermissionCommand()}}. Instead I fixed Shell Executor to scan command for null entries and fail fast, with better text. 

Irrespective of what jenkins says, this patch needs to be tested against a windows host






> Shell operations to fail with meaningful errors on windows if winutils.exe not found
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10775
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10775
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: trunk-win
>         Environment: Apache jenkins windows1 server
>            Reporter: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other causes, then an error is logged -but when any of the {{Shell}} operations are used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before any attempt to invoke a winutils-driven process made



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)