[GitHub] kevinjmh commented on a change in pull request #3108: [CARBONDATA-3277] Support to show child query for preaggregate/mv datamap

[GitBox <gi...@apache.org>]

kevinjmh commented on a change in pull request #3108: [CARBONDATA-3277] Support to show child query for preaggregate/mv datamap
URL: https://github.com/apache/carbondata/pull/3108#discussion_r251377913
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonDataMapShowCommand.scala
 ##########
 @@ -43,7 +44,8 @@ case class CarbonDataMapShowCommand(tableIdentifier: Option[TableIdentifier])
     Seq(AttributeReference("DataMapName", StringType, nullable = false)(),
       AttributeReference("ClassName", StringType, nullable = false)(),
       AttributeReference("Associated Table", StringType, nullable = false)(),
-      AttributeReference("DataMap Properties", StringType, nullable = false)())
+      AttributeReference("DataMap Properties", StringType, nullable = false)(),
+      AttributeReference("Child Query", StringType, nullable = false)())
 
 Review comment:
   The reason to use "Child Query" is that I saw the method name `PreAggregateUtil.getChildQuery`.  The one used in MV is "CtasQuery". 
   
   Refer to [Oracle MV doc](https://docs.oracle.com/cd/B10501_01/server.920/a96540/img_text/create_materialized_view.htm ) , the corresponding part is called "subquery". How about it?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services