Re: svn commit: r465145 [1/2] - in /incubator/cxf/trunk: ./ api/src/main/java/org/apache/cxf/ api/src/main/java/org/apache/cxf/binding/ api/src/main/java/org/apache/cxf/endpoint/ api/src/main/java/org/apache/cxf/interceptor/ api/src/main/java/org/apache/cx...

[Andrea Smyth <an...@iona.com>]

dandiep@apache.org wrote:

>Author: dandiep
>Date: Tue Oct 17 22:14:04 2006
>New Revision: 465145
>
>URL: http://svn.apache.org/viewvc?view=rev&rev=465145
>Log:
>o Client side fault support. This mostly involved writing the ClientFaultConverter
>  interceptor which takes a Detail and turns it into an exception. ServiceFactories
>  also had to be improved a bit.
>o As part of the ClientImpl changes needed for fault support, I needed to straigten
>  out correlation a bit. It is now the transport's responsibility to set the exchange
>  on the message and the message on the exchange (unless the transport is completely
>  async). This can be done by simply calling exchange.setInMessage(msg).
>o IMPORTANT: this seems to somehow break WS-Addressing systests. I've commented them
>  out, but I would appreciate some help figuring out whats going on as I can't figure
>  it out for the life of me! This may be related to the partial response logic I
>  removed, but I tried reenabling it to no avail.
>  
>
I'll take a look at that tomorrow - as I need the test working before 
starting off with an RM system test.
Andrea.

>o I removed the partial response logic as it didn't seem to be doing much (see above
>  - correct me if I'm completely wrong). I don't think the ClientImpl is the right
>  place to put the logic. To me it would seem much more appropriate for the ws-rm
>  implementation to register its own MessageObserver. I will bring this up on the
>  list though.
>o The JAXBEncoderDecoder wasn't always returning the inner value of the JAXBElement
>  and so it was returning a JAXBElement for faults instead of the fault bean. I don't
>  see any reason to return a JAXBElement and it doesn't seem to break anything, so
>  I changed it. Please correct me if I'm wrong.
>o Remove ServiceManager as its not needed.
>
>  
>