You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Reser <be...@reser.org> on 2012/10/21 20:35:09 UTC
Re: svn commit: r1400498 - /subversion/trunk/subversion/svnadmin/main.c
On Sat, Oct 20, 2012 at 11:35 AM, <st...@apache.org> wrote:
> Author: stefan2
> Date: Sat Oct 20 18:35:24 2012
> New Revision: 1400498
>
> URL: http://svn.apache.org/viewvc?rev=1400498&view=rev
> Log:
> On systems without efficient 64 bit atomics, svnadmin should not attempt
> to enable revprop caching because FSFS will reject it and log a warning.
> svnadmin writes the latter to stderr - which confuses our tests.
>
> * subversion/svnadmin/main.c
> (open_repos): enable revprop caching only if efficient
>
> Modified:
> subversion/trunk/subversion/svnadmin/main.c
What value does the revprop cache have for svnadmin? Are there any
operations that would actually look at revprops more than once in a
single svnadmin run?
Re: svn commit: r1400498 - /subversion/trunk/subversion/svnadmin/main.c
Posted by Ben Reser <be...@reser.org>.
On Sun, Oct 21, 2012 at 11:56 AM, Stefan Fuhrmann
<st...@wandisco.com> wrote:
> All caches are enabled by default. With revprop packing,
> we read the whole packed revprop file only once and put
> all items into the cache. That speeds up dump & friends.
>
> Also, any manipulation to some revprop will instantly
> become visible to all other processes (cache invalidation).
Ok thanks, makes sense.
Re: svn commit: r1400498 - /subversion/trunk/subversion/svnadmin/main.c
Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Sun, Oct 21, 2012 at 8:35 PM, Ben Reser <be...@reser.org> wrote:
> On Sat, Oct 20, 2012 at 11:35 AM, <st...@apache.org> wrote:
> > Author: stefan2
> > Date: Sat Oct 20 18:35:24 2012
> > New Revision: 1400498
> >
> > URL: http://svn.apache.org/viewvc?rev=1400498&view=rev
> > Log:
> > On systems without efficient 64 bit atomics, svnadmin should not attempt
> > to enable revprop caching because FSFS will reject it and log a warning.
> > svnadmin writes the latter to stderr - which confuses our tests.
> >
> > * subversion/svnadmin/main.c
> > (open_repos): enable revprop caching only if efficient
> >
> > Modified:
> > subversion/trunk/subversion/svnadmin/main.c
>
> What value does the revprop cache have for svnadmin? Are there any
> operations that would actually look at revprops more than once in a
> single svnadmin run?
>
All caches are enabled by default. With revprop packing,
we read the whole packed revprop file only once and put
all items into the cache. That speeds up dump & friends.
Also, any manipulation to some revprop will instantly
become visible to all other processes (cache invalidation).
-- Stefan^2.
--
*
Join us this October at Subversion Live
2012<http://www.wandisco.com/svn-live-2012>
for two days of best practice SVN training, networking, live demos,
committer meet and greet, and more! Space is limited, so get signed up
today<http://www.wandisco.com/svn-live-2012>
!
*