You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (JIRA)" <ji...@apache.org> on 2016/06/07 14:35:21 UTC
[jira] [Comment Edited] (QPID-7229) [Java Broker] Update Dojo to
1.11.1
[ https://issues.apache.org/jira/browse/QPID-7229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318569#comment-15318569 ]
Alex Rudyy edited comment on QPID-7229 at 6/7/16 2:35 PM:
----------------------------------------------------------
Attached diffs with changes upgrading dojo toolkit to v1.11.1( QPID-7229-upgrade-dojo-to-v1.11.1.diff) and changing WMC theme from 'claro' to 'flat' (QPID-7229-change-WMC-skin-from-claro-to-flat.diff)
Custom built dojo distribution bundle was used as official maven dojo bundle does not contain new themes.
I tested WMC console with changes in the patches attached and it seems in order to migrate to 'flat' theme we need to do a number of changes in the UI in order to fix the following:
* dojo Tree expand icon is not rendered properly. The font glyph is missed. That seems to be an issue with flat theme itself as the same missing glyph is displayed in official demo [http://download.dojotoolkit.org/release-1.11.1/dojo-release-1.11.1/themes/flat/tests/flat.html]
* there is no support for DataGrid and EnchancedGrid. Thus, claro/tundra themes were used but that did not look pretty. At least the following needs to be addressed:
** yellow grid rows separation does not look nice
** spaces between grid cells and rows
** row selection is pail-blue does not look matching with entire design concept
** yellow-gray column headers need more work
** blue page navigation link look Ok but color could be changed to match the UI look and feel
* MultiLists styles render MultiLists with shadows. That looks odd but it seems it is by design as they are rendered in the same way on demo [Flat Demo|http://download.dojotoolkit.org/release-1.11.1/dojo-release-1.11.1/themes/flat/tests/flat.html]
* Checkboxes are not rendered consistently within tabs and grids
** dgrid selection checkbox is displayed using default browser style
** In many Qpid specific UI checkboxes are displayed using default browser style
* MemoryLogger logviewing UI needs some work to change icons and tools to match new flat theme
* Some dijit icons are not implemented in flat theme and displayed using turn-around question mark
** icons on VHN and VH buttons under VH grid on Broker tab
* Qpid own icons needs to be re-drown, for example, warning icons with exclamation symbol on blue background is not centered properly
was (Author: alex.rufous):
Attached diffs with changes upgrading dojo toolkit to v1.11.1( QPID-7229-upgrade-dojo-to-v1.11.1.diff) and changing WMC theme from 'claro' to 'flat' (QPID-7229-change-WMC-skin-from-claro-to-flat.diff)
Custom built dojo distribution bundle was used as official maven dojo bundle does not contain new themes.
I tested WMC console with changes in the patches attached and it seems in order to migrate to 'flat' theme we need to do a number of changes in the UI in order to fix the following:
* dojo Tree expand icon is not rendered properly. The font glyph is missed. That seems to be an issue with flat theme itself as the same missing glyph is displayed in official demo [http://download.dojotoolkit.org/release-1.11.1/dojo-release-1.11.1/themes/flat/tests/flat.html]
* there is no support for DataGrid and EnchancedGrid. Thus, claro/tundra themes were used but that did not look pretty. At least the following needs to be addressed:
** yellow grid rows separation does not look nice
** spaces between grid cells and rows
** row selection is pail-blue does not look matching with entire design concept
** yellow-gray column headers need more work
** blue page navigation link look Ok but color could be changed to match the UI look and feel
* MultiLists styles render MultiLists with shadows. That looks odd but it seems it is by design as they are rendered in the same way on demo [Flat Demo|http://download.dojotoolkit.org/release-1.11.1/dojo-release-1.11.1/themes/flat/tests/flat.html]
* Checkboxes are not rendered consistently within tabs and grids
** dgrid selection checkbox is displayed using default browser style
** In many Qpid specific UI checkboxes are displayed using default browser style
* MemoryLogger logviewing UI needs some work to change icons and tools to match new flat theme
> [Java Broker] Update Dojo to 1.11.1
> -----------------------------------
>
> Key: QPID-7229
> URL: https://issues.apache.org/jira/browse/QPID-7229
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Fix For: qpid-java-6.1
>
> Attachments: QPID-7229-change-WMC-skin-from-claro-to-flat.diff, QPID-7229-upgrade-dojo-to-v1.11.1.diff
>
>
> Upgrade the Java Broker to the latest Dojo 1 release (1.11.1) and adopt the new 'modern' theme.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org