You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Berenguer Blasi (Jira)" <ji...@apache.org> on 2022/10/17 11:48:00 UTC
[jira] [Comment Edited] (CASSANDRA-17964) Some tests are never executed due to naming violation - fix it and add checkstyle where applicable
[ https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618847#comment-17618847 ]
Berenguer Blasi edited comment on CASSANDRA-17964 at 10/17/22 11:47 AM:
------------------------------------------------------------------------
Do IIUC correctly you're trying to detect the string 'Tests' in filenames? I would change the regexp to fail on anything with the word 'Test' that is not '\*Test.java'. I am thinking files named like 'TestForFeatureA.java' should also trigger the warning.
was (Author: bereng):
Do IIUC correctly you're trying to detect the string 'Tests' in filenames? I would change the regexp to fail on anything with the word 'Test' that is not 'Test.java'. I am thinking files named like 'TestForFeatureA.java'
> Some tests are never executed due to naming violation - fix it and add checkstyle where applicable
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Ruslan Fomkin
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java] doesn't follow naming convention to be run as unit tests and, thus, is never run.
> The rule in build expects names as `*Test`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org