You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/18 16:51:14 UTC
[jira] [Commented] (THRIFT-2901) Fix for generated TypeScript
functions + indentation of JavaScript maps
[ https://issues.apache.org/jira/browse/THRIFT-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251830#comment-14251830 ]
ASF GitHub Bot commented on THRIFT-2901:
----------------------------------------
GitHub user Kirby1337 opened a pull request:
https://github.com/apache/thrift/pull/332
THRIFT-2901
Fix for generated TypeScript functions + indentation of JavaScript maps
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/siemens/thrift THRIFT-2901
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/332.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #332
----
commit ff30d842dac58e12a3ce06cb8db67a98774af21d
Author: Kirby1337 <pa...@hispeed.ch>
Date: 2014-12-18T15:41:10Z
THRIFT-2901
Fix for generated TypeScript functions + indentation of JavaScript maps
----
> Fix for generated TypeScript functions + indentation of JavaScript maps
> -----------------------------------------------------------------------
>
> Key: THRIFT-2901
> URL: https://issues.apache.org/jira/browse/THRIFT-2901
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler
> Affects Versions: 0.9.1
> Reporter: Pascal Schweizer
> Labels: bug, javascript, typescript
> Fix For: 0.9.2
>
>
> The currently generated TypeScript functions that have no parameters, but include a callback, contain an extra comma in the parameter list.
> Example: function(, callback: Function){...}
> This patch fixes this problem and also corrects the indentation for generated JavaScript maps, which looked different from the rest.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)