[GitHub] spark pull request #18306: [SPARK-21029][SS] All StreamingQuery should be st...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18306#discussion_r136410312
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -562,6 +563,8 @@ class SparkContext(config: SparkConf) extends Logging {
           }
         _cleaner.foreach(_.start())
     
    +    _stopHooks = new SparkShutdownHookManager()
    --- End diff --
    
    there's already a shutdown hook to call sc.stop() - perhaps just add the clean up in stop()
    https://github.com/aray/spark/blob/005472ed10fad3d1bc8feff12fc55c5682724a0e/core/src/main/scala/org/apache/spark/SparkContext.scala#L584



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org