You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "framlog (via GitHub)" <gi...@apache.org> on 2023/04/03 07:04:34 UTC
[GitHub] [arrow-rs] framlog opened a new pull request, #4003: feat: support to read/write customized metadata in ipc files
framlog opened a new pull request, #4003:
URL: https://github.com/apache/arrow-rs/pull/4003
Test Plan: Pass CI
It adds APIs to support to read/write customized metadata in IPC files.
It should close #3549.
A pair of new APIs are added in this pr. Please pay more attention to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4003: feat: support to read/write customized metadata in ipc files
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4003:
URL: https://github.com/apache/arrow-rs/pull/4003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] framlog commented on a diff in pull request #4003: feat: support to read/write customized metadata in ipc files
Posted by "framlog (via GitHub)" <gi...@apache.org>.
framlog commented on code in PR #4003:
URL: https://github.com/apache/arrow-rs/pull/4003#discussion_r1155826512
##########
arrow-ipc/src/writer.rs:
##########
@@ -798,13 +805,24 @@ impl<W: Write> FileWriter<W> {
let dictionaries = fbb.create_vector(&self.dictionary_blocks);
let record_batches = fbb.create_vector(&self.record_blocks);
let schema = crate::convert::schema_to_fb_offset(&mut fbb, &self.schema);
+ let fb_custom_metadata = if !self.custom_metadata.is_empty() {
Review Comment:
OK. I switched to that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4003: feat: support to read/write customized metadata in ipc files
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4003:
URL: https://github.com/apache/arrow-rs/pull/4003#issuecomment-1494183979
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4003: feat: support to read/write customized metadata in ipc files
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4003:
URL: https://github.com/apache/arrow-rs/pull/4003#discussion_r1155695485
##########
arrow-ipc/src/writer.rs:
##########
@@ -798,13 +805,24 @@ impl<W: Write> FileWriter<W> {
let dictionaries = fbb.create_vector(&self.dictionary_blocks);
let record_batches = fbb.create_vector(&self.record_blocks);
let schema = crate::convert::schema_to_fb_offset(&mut fbb, &self.schema);
+ let fb_custom_metadata = if !self.custom_metadata.is_empty() {
Review Comment:
This could be written with `Option::then`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org