You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Scott Wilson (JIRA)" <ji...@apache.org> on 2011/06/17 17:56:47 UTC
[jira] [Created] (RAVE-71) Users can review and rate Widgets in the
Widget Repository
Users can review and rate Widgets in the Widget Repository
----------------------------------------------------------
Key: RAVE-71
URL: https://issues.apache.org/jira/browse/RAVE-71
Project: Rave
Issue Type: Story
Reporter: Scott Wilson
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "Jasha Joachimsthal (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal reassigned RAVE-71:
--------------------------------------
Assignee: (was: Jasha Joachimsthal)
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
>
> Planning to apply the patch next week
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125119#comment-13125119 ]
jiraposter@reviews.apache.org commented on RAVE-71:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2338/
-----------------------------------------------------------
Review request for rave.
Summary
-------
Partial Patch which allows users to rate widgets from the detailed widget view.
This patch does NOT include a UI to view the user's current rating for a widget, nor does it include the UI for showing the rating totals for a given widget.
Questions for the team
1) Do we want to add the ability to rate widgets from the widget store (non-detailed page)?
2) Do we want to add the ability to rate widgets from the widget menu on a user's page?
3) Do we want to include totals of the ratings? (e.g. 314 Liked, 2014 Disliked)
3) How should we handle the display of the rating for the user?
a) Iterate over object model to determine user's current rating and totals - This will result in performance issues when a lot of users have provided ratings for widgets.
b) Create a statistics service to query the database directly and attach this statistical information to the object model - This will result in a hard coded SQL query to gather this information and requires attaching more information to the web model, as well as requiring mapping the various widget ratings to the widgets on the UI side.
c) Suggest another approach
This addresses bug RAVE-71.
https://issues.apache.org/jira/browse/RAVE-71
Diffs
-----
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1181810
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1181810
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1181810
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1181810
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java 1181810
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1181810
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1181810
/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1181810
/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1181810
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1181810
/trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1181810
Diff: https://reviews.apache.org/r/2338/diff
Testing
-------
Thanks,
Sean
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "Jasha Joachimsthal (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal reassigned RAVE-71:
--------------------------------------
Assignee: Jasha Joachimsthal
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
> Assignee: Jasha Joachimsthal
>
> Planning to apply the patch next week
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129854#comment-13129854 ]
jiraposter@reviews.apache.org commented on RAVE-71:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2402/
-----------------------------------------------------------
(Updated 2011-10-18 16:57:40.314623)
Review request for rave.
Changes
-------
Javascript update... IE changes the states of the button and radio values prior to firing the JQuery 'change' event so logic has been updated to assume the user had the opposing rating to the newly selected rating and subtracts one from the opposing rating total (still verifying that it is at least '0')
Summary
-------
Added widget ratings to the portal
This addresses bug RAVE-71.
https://issues.apache.org/jira/browse/RAVE-71
Diffs (updated)
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetRating.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/util/WidgetStatistics.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1185152
trunk/rave-components/rave-core/src/main/resources/META-INF/persistence.xml 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetRatingTest.java PRE-CREATION
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaWidgetRepositoryTest.java 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java 1185152
trunk/rave-components/rave-core/src/test/resources/test_data.sql 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1185152
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1185152
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1185152
trunk/rave-portal-resources/src/main/resources/messages.properties 1185152
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/store.jsp 1185152
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1185152
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1185152
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1185152
Diff: https://reviews.apache.org/r/2402/diff
Testing
-------
Thanks,
Sean
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "Jasha Joachimsthal (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal resolved RAVE-71.
------------------------------------
Resolution: Fixed
Applied the second patch but moved the WidgetRating related operations to the WidgetRatingService/Repostory.
Thanks Sean for your patches!
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
> Assignee: Jasha Joachimsthal
>
> Planning to apply the patch next week
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "Jasha Joachimsthal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136248#comment-13136248 ]
Jasha Joachimsthal commented on RAVE-71:
----------------------------------------
reassigning this issue to myself. I probably have applied the wrong patch version. Will fix that soon.
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
> Assignee: Jasha Joachimsthal
>
> Planning to apply the patch next week
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-71) Users can review and rate Widgets in the
Widget Repository
Posted by "Jasha Joachimsthal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal updated RAVE-71:
-----------------------------------
Fix Version/s: (was: 0.5-INCUBATING)
Applied the patch from https://reviews.apache.org/r/2402/ with some modifications
The total rating of a widget is still invisible and you cannot yet delete the rating.
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
> Assignee: Jasha Joachimsthal
>
> Planning to apply the patch next week
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "Jasha Joachimsthal (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal reassigned RAVE-71:
--------------------------------------
Assignee: Jasha Joachimsthal
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
> Assignee: Jasha Joachimsthal
> Fix For: 0.5-INCUBATING
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-71) Users can review and rate Widgets in the
Widget Repository
Posted by "Jasha Joachimsthal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal updated RAVE-71:
-----------------------------------
Description: Planning to apply the patch next week
Fix Version/s: 0.5-INCUBATING
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
> Assignee: Jasha Joachimsthal
> Fix For: 0.5-INCUBATING
>
>
> Planning to apply the patch next week
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134000#comment-13134000 ]
jiraposter@reviews.apache.org commented on RAVE-71:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2402/#review2787
-----------------------------------------------------------
Ship it!
Applied your patch with some changes. Iterating over a List of WidgetRatings per Widget can get very expensive if thousands of users rate a widget so I created a new repository + service that get the WidgetRating for a specific widget/user combination.
I saw that the deleteWidgetRating is not in use yet and it's not visible what the rating of a widget is.
- Jasha
On 2011-10-18 16:57:40, Sean Cooper wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2402/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-18 16:57:40)
bq.
bq.
bq. Review request for rave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added widget ratings to the portal
bq.
bq.
bq. This addresses bug RAVE-71.
bq. https://issues.apache.org/jira/browse/RAVE-71
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1185152
bq. trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetRating.java PRE-CREATION
bq. trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/util/WidgetStatistics.java PRE-CREATION
bq. trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1185152
bq. trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1185152
bq. trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1185152
bq. trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1185152
bq. trunk/rave-components/rave-core/src/main/resources/META-INF/persistence.xml 1185152
bq. trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetRatingTest.java PRE-CREATION
bq. trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1185152
bq. trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaWidgetRepositoryTest.java 1185152
bq. trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java 1185152
bq. trunk/rave-components/rave-core/src/test/resources/test_data.sql 1185152
bq. trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1185152
bq. trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1185152
bq. trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1185152
bq. trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1185152
bq. trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1185152
bq. trunk/rave-portal-resources/src/main/resources/messages.properties 1185152
bq. trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/store.jsp 1185152
bq. trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1185152
bq. trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1185152
bq. trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1185152
bq.
bq. Diff: https://reviews.apache.org/r/2402/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sean
bq.
bq.
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
> Assignee: Jasha Joachimsthal
> Fix For: 0.5-INCUBATING
>
>
> Planning to apply the patch next week
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128907#comment-13128907 ]
jiraposter@reviews.apache.org commented on RAVE-71:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2402/
-----------------------------------------------------------
Review request for rave.
Summary
-------
Added widget ratings to the portal
This addresses bug RAVE-71.
https://issues.apache.org/jira/browse/RAVE-71
Diffs
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetRating.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/util/WidgetStatistics.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1185152
trunk/rave-components/rave-core/src/main/resources/META-INF/persistence.xml 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetRatingTest.java PRE-CREATION
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaWidgetRepositoryTest.java 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java 1185152
trunk/rave-components/rave-core/src/test/resources/test_data.sql 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1185152
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1185152
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1185152
trunk/rave-portal-resources/src/main/resources/messages.properties 1185152
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/store.jsp 1185152
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1185152
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1185152
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1185152
Diff: https://reviews.apache.org/r/2402/diff
Testing
-------
Thanks,
Sean
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128370#comment-13128370 ]
jiraposter@reviews.apache.org commented on RAVE-71:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2338/#review2612
-----------------------------------------------------------
The WidgetRating class is missing in the patch. Can you create a new patch that includes this class (and possibly other classes that don't exist yet)?
- Jasha
On 2011-10-11 15:32:31, Sean Cooper wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2338/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-11 15:32:31)
bq.
bq.
bq. Review request for rave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Partial Patch which allows users to rate widgets from the detailed widget view.
bq.
bq. This patch does NOT include a UI to view the user's current rating for a widget, nor does it include the UI for showing the rating totals for a given widget.
bq.
bq. Questions for the team
bq. 1) Do we want to add the ability to rate widgets from the widget store (non-detailed page)?
bq. 2) Do we want to add the ability to rate widgets from the widget menu on a user's page?
bq. 3) Do we want to include totals of the ratings? (e.g. 314 Liked, 2014 Disliked)
bq. 3) How should we handle the display of the rating for the user?
bq. a) Iterate over object model to determine user's current rating and totals - This will result in performance issues when a lot of users have provided ratings for widgets.
bq. b) Create a statistics service to query the database directly and attach this statistical information to the object model - This will result in a hard coded SQL query to gather this information and requires attaching more information to the web model, as well as requiring mapping the various widget ratings to the widgets on the UI side.
bq. c) Suggest another approach
bq.
bq.
bq. This addresses bug RAVE-71.
bq. https://issues.apache.org/jira/browse/RAVE-71
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1181810
bq. /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1181810
bq. /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1181810
bq. /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1181810
bq. /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java 1181810
bq. /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1181810
bq. /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1181810
bq. /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1181810
bq. /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1181810
bq. /trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1181810
bq. /trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1181810
bq.
bq. Diff: https://reviews.apache.org/r/2338/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sean
bq.
bq.
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125696#comment-13125696 ]
jiraposter@reviews.apache.org commented on RAVE-71:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2338/#review2529
-----------------------------------------------------------
Thanks for the submitted patch. I have a few remarks.
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java
<https://reviews.apache.org/r/2338/#comment5698>
Please add tests in JpaWidgetRepositoryTest that proves the correct behaviour in CRUD operations instead of only mocking the result in the Service.
You probably need to set the Widget (this) to the new WidgetRating) to let the OneToMany relation work properly. Add a method addRating(WidgetRating rating) to add a single WidgetRating.
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java
<https://reviews.apache.org/r/2338/#comment5699>
shouldn't the save and delete be "void"?
why are the input variables different between these methods?
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java
<https://reviews.apache.org/r/2338/#comment5700>
This makes it possible to do a request for any userid. Shouldn't the user id be retrieved from the request (current authenticated user)?
Why is widgetId a long primitive and userId a Long object?
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java
<https://reviews.apache.org/r/2338/#comment5701>
This makes it possible to do a request for any userid. Shouldn't the user id be retrieved from the request (current authenticated user)?
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp
<https://reviews.apache.org/r/2338/#comment5702>
Please use message keys instead of hard coded text
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp
<https://reviews.apache.org/r/2338/#comment5703>
Please move this inline script to an (existing) external scriptfile
- Jasha
On 2011-10-11 15:32:31, Sean Cooper wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2338/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-11 15:32:31)
bq.
bq.
bq. Review request for rave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Partial Patch which allows users to rate widgets from the detailed widget view.
bq.
bq. This patch does NOT include a UI to view the user's current rating for a widget, nor does it include the UI for showing the rating totals for a given widget.
bq.
bq. Questions for the team
bq. 1) Do we want to add the ability to rate widgets from the widget store (non-detailed page)?
bq. 2) Do we want to add the ability to rate widgets from the widget menu on a user's page?
bq. 3) Do we want to include totals of the ratings? (e.g. 314 Liked, 2014 Disliked)
bq. 3) How should we handle the display of the rating for the user?
bq. a) Iterate over object model to determine user's current rating and totals - This will result in performance issues when a lot of users have provided ratings for widgets.
bq. b) Create a statistics service to query the database directly and attach this statistical information to the object model - This will result in a hard coded SQL query to gather this information and requires attaching more information to the web model, as well as requiring mapping the various widget ratings to the widgets on the UI side.
bq. c) Suggest another approach
bq.
bq.
bq. This addresses bug RAVE-71.
bq. https://issues.apache.org/jira/browse/RAVE-71
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1181810
bq. /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1181810
bq. /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1181810
bq. /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1181810
bq. /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java 1181810
bq. /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1181810
bq. /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1181810
bq. /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1181810
bq. /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1181810
bq. /trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1181810
bq. /trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1181810
bq.
bq. Diff: https://reviews.apache.org/r/2338/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sean
bq.
bq.
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-71) Users can review and rate Widgets in
the Widget Repository
Posted by "Sean Cooper (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128906#comment-13128906 ]
Sean Cooper commented on RAVE-71:
---------------------------------
Updated patch
https://reviews.apache.org/r/2402/
> Users can review and rate Widgets in the Widget Repository
> ----------------------------------------------------------
>
> Key: RAVE-71
> URL: https://issues.apache.org/jira/browse/RAVE-71
> Project: Rave
> Issue Type: Story
> Reporter: Scott Wilson
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira