You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by do...@apache.org on 2003/01/01 19:43:51 UTC

cvs commit: modperl-2.0 STATUS

dougm       2003/01/01 10:43:51

  Modified:    .        STATUS
  Log:
  must be fixed before 1.99_08
  
  Revision  Changes    Path
  1.28      +3 -5      modperl-2.0/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/STATUS,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- STATUS	1 Jan 2003 03:45:54 -0000	1.27
  +++ STATUS	1 Jan 2003 18:43:51 -0000	1.28
  @@ -24,11 +24,9 @@
   Release Showstoppers:
   ---------------------
   
  - * 
  -   Report: 
  -   Status: 
  -
  + * current cvs does not work with vanilla 5.6.1 or 5.8.0 (CGI.pm version issue)
   
  + * Makefile.PL process ugly "unknown typemap" warnings must go away
   
   Available Patches:
   ------------------
  
  
  

Re: cvs commit: modperl-2.0 STATUS

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On 1 Jan 2003 dougm@apache.org wrote:
> 
> 
>>dougm       2003/01/01 10:43:51
>>
>>  Modified:    .        STATUS
>>  Log:
>>  must be fixed before 1.99_08
>>  
>>  Revision  Changes    Path
>>  1.28      +3 -5      modperl-2.0/STATUS
>>  
>>  + * Makefile.PL process ugly "unknown typemap" warnings must go away
> 
> 
> What about something like the following?
> 
> ====================================================================
> Index: lib/ModPerl/TypeMap.pm
> ===================================================================
> RCS file: /home/cvspublic/modperl-2.0/lib/ModPerl/TypeMap.pm,v
> retrieving revision 1.18
> diff -u -r1.18 TypeMap.pm
> --- lib/ModPerl/TypeMap.pm	30 Dec 2002 00:27:13 -0000	1.18
> +++ lib/ModPerl/TypeMap.pm	1 Jan 2003 22:33:58 -0000
> @@ -6,6 +6,7 @@
>  use ModPerl::FunctionMap ();
>  use ModPerl::StructureMap ();
>  use ModPerl::MapUtil qw(list_first);
> +use Apache::TestTrace qw(debug);
>  
>  our @ISA = qw(ModPerl::MapBase);
>  
> @@ -235,7 +236,7 @@
>              map $_->{type}, @{ $func->{args} });
>  
>      unless ($status) {
> -        warn "unknown typemap: '$failed_type' (skipping $func->{name})\n";
> +        debug "unknown typemap: '$failed_type' (skipping $func->{name})\n";
>          return;
>      }

This is the same as saying
   #warn "unknown...
because the default level is 'info' and there is no way to enable 
'debug', without changing the code. TestTrace is a testing package, not 
a build package. You can modify the trace level in TestTrace when you 
run TestRun: t/TEST -trace=debug
Seems like we have used a bunch of trace calls in the build code which 
will never be invoked, which should be fixed as well.

I think the right solution in this particular case is to fix the map 
files. These unresolved types has be fixed anyways before the skipped 
functions can be enabled.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: cvs commit: modperl-2.0 STATUS

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On 1 Jan 2003 dougm@apache.org wrote:

> dougm       2003/01/01 10:43:51
> 
>   Modified:    .        STATUS
>   Log:
>   must be fixed before 1.99_08
>   
>   Revision  Changes    Path
>   1.28      +3 -5      modperl-2.0/STATUS
>   
>   + * Makefile.PL process ugly "unknown typemap" warnings must go away

What about something like the following?

====================================================================
Index: lib/ModPerl/TypeMap.pm
===================================================================
RCS file: /home/cvspublic/modperl-2.0/lib/ModPerl/TypeMap.pm,v
retrieving revision 1.18
diff -u -r1.18 TypeMap.pm
--- lib/ModPerl/TypeMap.pm	30 Dec 2002 00:27:13 -0000	1.18
+++ lib/ModPerl/TypeMap.pm	1 Jan 2003 22:33:58 -0000
@@ -6,6 +6,7 @@
 use ModPerl::FunctionMap ();
 use ModPerl::StructureMap ();
 use ModPerl::MapUtil qw(list_first);
+use Apache::TestTrace qw(debug);
 
 our @ISA = qw(ModPerl::MapBase);
 
@@ -235,7 +236,7 @@
             map $_->{type}, @{ $func->{args} });
 
     unless ($status) {
-        warn "unknown typemap: '$failed_type' (skipping $func->{name})\n";
+        debug "unknown typemap: '$failed_type' (skipping $func->{name})\n";
         return;
     }
 
========================================================================

-- 
best regards,
randy


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org