You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/05 21:24:57 UTC
[GitHub] [airflow] ashb opened a new pull request, #26168: Add triggering dataset events to ti context
ashb opened a new pull request, #26168:
URL: https://github.com/apache/airflow/pull/26168
This allows downstream tasks to get details about the events that
triggered the dagrun.
Since this is going to be infrequently accessed, and is "somewhat" expensive (join two extra tables) it has been added to the context as a lazy Proxy
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #26168: Add triggering dataset events to ti context
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #26168:
URL: https://github.com/apache/airflow/pull/26168#discussion_r963452811
##########
airflow/utils/context.pyi:
##########
@@ -86,6 +87,7 @@ class Context(TypedDict, total=False):
ti: TaskInstance
tomorrow_ds: str
tomorrow_ds_nodash: str
+ triggering_dataset_events: Dict[str, List[DatasetEvent]]
Review Comment:
```suggestion
triggering_dataset_events: Mapping[str, Collection[DatasetEvent]]
```
Let’s keep the type vague so we can optimise things if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #26168: Add triggering dataset events to ti context
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26168:
URL: https://github.com/apache/airflow/pull/26168#issuecomment-1237997169
Random thought: I wonder if we should make _everything_ in the Context lazy by default? (but using a custom `__getitem__` instead of needing lazy Proxy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #26168: Add triggering dataset events to ti context
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #26168:
URL: https://github.com/apache/airflow/pull/26168#issuecomment-1238429959
> but using a custom `__getitem__` instead of needing lazy Proxy
I tried this but it introduces very poor behaviour to `**kwargs` usages (which is quite common for taskflow users, to my surprise), so I switched to the current approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #26168: Add triggering dataset events to ti context
Posted by GitBox <gi...@apache.org>.
ashb merged PR #26168:
URL: https://github.com/apache/airflow/pull/26168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org