You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/02 11:31:34 UTC
[GitHub] [superset] PMExtra opened a new pull request #17320: Improve health check for docker-compose.
PMExtra opened a new pull request #17320:
URL: https://github.com/apache/superset/pull/17320
For now, all services in docker-compose that using superset image will inherit the health check from the image. But the image is built for web app default.
So I made this change that using `celery inspect ping` for worker health check. And it also disabled health check for init and worker-beat services because they are always failed (unhealthy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kakoni commented on pull request #17320: other: Improve health check for docker-compose.
Posted by GitBox <gi...@apache.org>.
kakoni commented on pull request #17320:
URL: https://github.com/apache/superset/pull/17320#issuecomment-1064026956
@PMExtra
For worker-beat one could do
```
healthcheck:
test: ["CMD-SHELL", "[ -f /proc/$$(cat /tmp/celerybeat.pid)/status ]"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kakoni commented on pull request #17320: other: Improve health check for docker-compose.
Posted by GitBox <gi...@apache.org>.
kakoni commented on pull request #17320:
URL: https://github.com/apache/superset/pull/17320#issuecomment-1066568609
@PMExtra Ah right, thats correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] PMExtra commented on pull request #17320: other: Improve health check for docker-compose.
Posted by GitBox <gi...@apache.org>.
PMExtra commented on pull request #17320:
URL: https://github.com/apache/superset/pull/17320#issuecomment-1066542155
@kakoni I don't think so. It only checks if the process exists. But a health-check should check if the function effective.
And I think it make an unnecessary move. if the process is quit, the `celery` command should return and the container should be stopped.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org