m2 & experimental imap in trunk

[Stefano Bagnara <ap...@bago.org>]

Hi Robert,

I just updated m2 stuff in trunk and I have noticed few things:

- many imap classes use tabs indentation instead of spaces (spaces are
the standard for the JAMES project).

- 12 tests in ImapResponseTest fail.

- I saw there is a jdom dependency: what is the dependency path to this
one? I can't find what code/library has dependency on this.

Thank you,
Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: m2 & experimental imap in trunk

[Stefano Bagnara <ap...@bago.org>]

robert burrell donkin ha scritto:
> On 7/4/07, Stefano Bagnara <ap...@bago.org> wrote:
>> I fixed them in r553342: if you have conflict just override my change,
>> and I'll reformat sources again.
> 
> thanks
> 
> (not sure why my scripts didn't work but then again my script-foo's not
> great)
> 
> - robert

I did it "manually", or better I used Eclipse facilities:
They were 2 single classes + 43 classes from 2 packages, so Search in
file for Tab, open the 2 single files CTRL-SHIFT-F, right click on the 2
packages "Source"=>"Format".

We also used to have an part of the ant script used to build james that
automatically converted tab to spaces so that after a build you would
have seen uncommitted changes, but I guess the ant snipped finished in
the phoenix deployment module, now.

Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: m2 & experimental imap in trunk

[robert burrell donkin <ro...@gmail.com>]

On 7/4/07, Stefano Bagnara <ap...@bago.org> wrote:
> Stefano Bagnara ha scritto:
> > robert burrell donkin ha scritto:
> >> On 7/4/07, robert burrell donkin <ro...@gmail.com> wrote:
> >>> On 7/4/07, Stefano Bagnara <ap...@bago.org> wrote:
> >>>> - many imap classes use tabs indentation instead of spaces (spaces are
> >>>> the standard for the JAMES project).
> >>> sorry about that - had some trouble a while ago when i switch eclipse
> >>> workspaces but i'd thought i'd corrected them all :-/
> >>>
> >>> i'll try running a script...
> >> can't seem to find any to fix :-/
> >>
> >> did you fix them all?
> >>
> >> - robert
> >
> > I only fixed mine in a previous commit. There are left 45 java files
> > with tabs in imap modules.
> >
> > If you want I can also fix IMAP stuff: I didn't do that because I would
> > have created conflicts if you have uncommitted code.
>
> I fixed them in r553342: if you have conflict just override my change,
> and I'll reformat sources again.

thanks

(not sure why my scripts didn't work but then again my script-foo's not great)

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: m2 & experimental imap in trunk

[Stefano Bagnara <ap...@bago.org>]

Stefano Bagnara ha scritto:
> robert burrell donkin ha scritto:
>> On 7/4/07, robert burrell donkin <ro...@gmail.com> wrote:
>>> On 7/4/07, Stefano Bagnara <ap...@bago.org> wrote:
>>>> - many imap classes use tabs indentation instead of spaces (spaces are
>>>> the standard for the JAMES project).
>>> sorry about that - had some trouble a while ago when i switch eclipse
>>> workspaces but i'd thought i'd corrected them all :-/
>>>
>>> i'll try running a script...
>> can't seem to find any to fix :-/
>>
>> did you fix them all?
>>
>> - robert
> 
> I only fixed mine in a previous commit. There are left 45 java files
> with tabs in imap modules.
> 
> If you want I can also fix IMAP stuff: I didn't do that because I would
> have created conflicts if you have uncommitted code.

I fixed them in r553342: if you have conflict just override my change,
and I'll reformat sources again.

Btw Eclipse, by default does not have a correct formatter. I usually
take the "Java Conventions" one and create a duplicate by only changing
"Tab Policy" to "Spaces only".

Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: m2 & experimental imap in trunk

[Stefano Bagnara <ap...@bago.org>]

robert burrell donkin ha scritto:
> On 7/4/07, robert burrell donkin <ro...@gmail.com> wrote:
>> On 7/4/07, Stefano Bagnara <ap...@bago.org> wrote:
>> > Hi Robert,
>> >
>> > I just updated m2 stuff in trunk and I have noticed few things:
>> >
>> > - many imap classes use tabs indentation instead of spaces (spaces are
>> > the standard for the JAMES project).
>>
>> sorry about that - had some trouble a while ago when i switch eclipse
>> workspaces but i'd thought i'd corrected them all :-/
>>
>> i'll try running a script...
> 
> can't seem to find any to fix :-/
> 
> did you fix them all?
> 
> - robert

I only fixed mine in a previous commit. There are left 45 java files
with tabs in imap modules.

If you want I can also fix IMAP stuff: I didn't do that because I would
have created conflicts if you have uncommitted code.

Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: m2 & experimental imap in trunk

[robert burrell donkin <ro...@gmail.com>]

On 7/4/07, robert burrell donkin <ro...@gmail.com> wrote:
> On 7/4/07, Stefano Bagnara <ap...@bago.org> wrote:
> > Hi Robert,
> >
> > I just updated m2 stuff in trunk and I have noticed few things:
> >
> > - many imap classes use tabs indentation instead of spaces (spaces are
> > the standard for the JAMES project).
>
> sorry about that - had some trouble a while ago when i switch eclipse
> workspaces but i'd thought i'd corrected them all :-/
>
> i'll try running a script...

can't seem to find any to fix :-/

did you fix them all?

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: m2 & experimental imap in trunk

[robert burrell donkin <ro...@gmail.com>]

On 7/4/07, Stefano Bagnara <ap...@bago.org> wrote:
> Hi Robert,
>
> I just updated m2 stuff in trunk and I have noticed few things:
>
> - many imap classes use tabs indentation instead of spaces (spaces are
> the standard for the JAMES project).

sorry about that - had some trouble a while ago when i switch eclipse
workspaces but i'd thought i'd corrected them all :-/

i'll try running a script...

> - 12 tests in ImapResponseTest fail.

sorry about that

ATM dist only runs tests in the phoenix-deployment module. IMHO it
would be better for dist to run the unit tests in each module. any
objections to me adding this to the build?

> - I saw there is a jdom dependency: what is the dependency path to this
> one? I can't find what code/library has dependency on this.

not sure

phoenix..?

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org