You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/17 23:11:49 UTC
[GitHub] [hbase] busbey opened a new pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
busbey opened a new pull request #1725:
URL: https://github.com/apache/hbase/pull/1725
Adds the ability to specify the remote git repo for the release scripts, including a local clone.
* adds a optional `-r [repo]` arg
* if the passed repo is on the local filesystem, creates a container mount
* git clone operations consolidated into a function
* when cloning a local repo configure git to share objects with the local repo instead of copying
* when cloning a local repo in a container configure the clone to have a remote that will work back on the host.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#discussion_r429420117
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
Review comment:
because it deletes the target directory before cloning. I could name it something like `git_clone_overwrite` if that's clearer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] asfgit closed pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1725:
URL: https://github.com/apache/hbase/pull/1725
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#discussion_r428329850
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -168,11 +172,65 @@ if [ -n "$JAVA" ]; then
JAVA_VOL=(--volume "$JAVA:/opt/hbase-java")
fi
+#TODO some debug output would be good here
+GIT_REPO_MOUNT=()
+if [ -n "${GIT_REPO}" ]; then
+ case "${GIT_REPO}" in
+ # skip the easy to identify remote protocols
+ ssh://*|git://*|http://*|https://*|ftp://*|ftps://*) ;;
+ # for sure local
+ /*)
+ GIT_REPO_MOUNT=(--mount "type=bind,src=${GIT_REPO},dst=/opt/hbase-repo")
+ echo "HOST_GIT_REPO=${GIT_REPO}" >> "${ENVFILE}"
+ GIT_REPO="/opt/hbase-repo"
+ ;;
+ # on the host but normally git wouldn't use the local optimization
+ file://*)
+ echo "[INFO] converted file:// git repo to a local path, which changes git to assume --local."
+ GIT_REPO_MOUNT=(--mount "type=bind,src=${GIT_REPO#file://},dst=/opt/hbase-repo")
+ echo "HOST_GIT_REPO=${GIT_REPO}" >> "${ENVFILE}"
+ GIT_REPO="/opt/hbase-repo"
+ ;;
+ # have to decide if it's a local path or the "scp-ish" remote
+ *)
Review comment:
Is it simpler to match on a regex like `(?<protocol>.+)://(?<host_and_path>.+)`? If this does not match, it's local for sure. if `protocol` matches as `file`, you treat `host_and_path` as a local path. Anything else you pass through as `GIT_REPO` and let git sort it out.
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
+ local asf_repo
+ if [ -d "${PROJECT}" ]; then
Review comment:
skip the `if [ -d` check? if there's something there, you want it removed. doesn't matter if it's a dir or not.
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
Review comment:
why is this function called "force"? is there some version that performs a clone more gracefully?
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
+ local asf_repo
+ if [ -d "${PROJECT}" ]; then
+ rm -rf "${PROJECT}"
+ fi
+
+ if [[ -z "${GIT_REPO}" ]]; then
+ asf_repo="gitbox.apache.org/repos/asf/${PROJECT}.git"
+ echo "[INFO] clone will be of the gitbox repo for ${PROJECT}."
+ if [ -n "${ASF_USERNAME}" ] && [ -n "${ASF_PASSWORD}" ]; then
+ # Ugly!
+ encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''')")
+ encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''')")
+ GIT_REPO="https://$encoded_username:$encoded_password@${asf_repo}"
+ else
+ GIT_REPO="https://${asf_repo}"
+ fi
+ else
+ echo "[INFO] clone will be of provided git repo."
+ fi
+ # N.B. we use the shared flag because the clone is short lived and if a local repo repo was
+ # given this will let us refer to objects there directly instead of hardlinks or copying.
+ # The option is silently ignored for non-local repositories. see the note on git help clone
+ # for the --shared option for details.
Review comment:
nice
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
+ local asf_repo
+ if [ -d "${PROJECT}" ]; then
+ rm -rf "${PROJECT}"
+ fi
+
+ if [[ -z "${GIT_REPO}" ]]; then
+ asf_repo="gitbox.apache.org/repos/asf/${PROJECT}.git"
+ echo "[INFO] clone will be of the gitbox repo for ${PROJECT}."
+ if [ -n "${ASF_USERNAME}" ] && [ -n "${ASF_PASSWORD}" ]; then
+ # Ugly!
+ encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''')")
+ encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''')")
+ GIT_REPO="https://$encoded_username:$encoded_password@${asf_repo}"
+ else
+ GIT_REPO="https://${asf_repo}"
+ fi
+ else
+ echo "[INFO] clone will be of provided git repo."
+ fi
+ # N.B. we use the shared flag because the clone is short lived and if a local repo repo was
+ # given this will let us refer to objects there directly instead of hardlinks or copying.
+ # The option is silently ignored for non-local repositories. see the note on git help clone
+ # for the --shared option for details.
+ git clone --shared -b "${GIT_BRANCH}" -- "${GIT_REPO}" "${PROJECT}"
+ # If this was a host local git repo then add in an alterntes and remote that will
+ # work back on the host if the RM needs to do any post-processing steps, i.e. pushing the git tag
Review comment:
this sounds like black-git-magic :)
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
+ local asf_repo
+ if [ -d "${PROJECT}" ]; then
+ rm -rf "${PROJECT}"
+ fi
+
+ if [[ -z "${GIT_REPO}" ]]; then
+ asf_repo="gitbox.apache.org/repos/asf/${PROJECT}.git"
+ echo "[INFO] clone will be of the gitbox repo for ${PROJECT}."
+ if [ -n "${ASF_USERNAME}" ] && [ -n "${ASF_PASSWORD}" ]; then
+ # Ugly!
+ encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''')")
+ encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''')")
+ GIT_REPO="https://$encoded_username:$encoded_password@${asf_repo}"
+ else
+ GIT_REPO="https://${asf_repo}"
+ fi
+ else
+ echo "[INFO] clone will be of provided git repo."
+ fi
+ # N.B. we use the shared flag because the clone is short lived and if a local repo repo was
Review comment:
small question, what does "N. B." stand for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#discussion_r429420672
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
+ local asf_repo
+ if [ -d "${PROJECT}" ]; then
+ rm -rf "${PROJECT}"
+ fi
+
+ if [[ -z "${GIT_REPO}" ]]; then
+ asf_repo="gitbox.apache.org/repos/asf/${PROJECT}.git"
+ echo "[INFO] clone will be of the gitbox repo for ${PROJECT}."
+ if [ -n "${ASF_USERNAME}" ] && [ -n "${ASF_PASSWORD}" ]; then
+ # Ugly!
+ encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''')")
+ encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''')")
+ GIT_REPO="https://$encoded_username:$encoded_password@${asf_repo}"
+ else
+ GIT_REPO="https://${asf_repo}"
+ fi
+ else
+ echo "[INFO] clone will be of provided git repo."
+ fi
+ # N.B. we use the shared flag because the clone is short lived and if a local repo repo was
Review comment:
the literal meaning is "Nota Bene" but in english it just means "hey pay attention to this"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#discussion_r429419080
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -71,6 +72,7 @@ Options:
-j [path] path to local JDK installation to use building. By default the script will
use openjdk8 installed in the docker image.
-p [project] project to build, such as 'hbase' or 'hbase-thirdparty'; defaults to $PROJECT env var
+ -r [repo] git repo to use for remote git operations. defaults to ASF gitbox for project.
Review comment:
yeah. on OS X any file operation we can avoid in a bind mount will help save us time. This skips both the network cost of cloning the remote repo (which is pretty big currently) and also skips local file copies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#issuecomment-629877289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
busbey commented on pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#issuecomment-632885793
I think this last push has the nits you mentioned cleaned up @ndimiduk.
Y'all let me know if you want to review things more. Otherwise I'll merge when I get some time this weekend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#discussion_r429421019
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
+ local asf_repo
+ if [ -d "${PROJECT}" ]; then
+ rm -rf "${PROJECT}"
+ fi
+
+ if [[ -z "${GIT_REPO}" ]]; then
+ asf_repo="gitbox.apache.org/repos/asf/${PROJECT}.git"
+ echo "[INFO] clone will be of the gitbox repo for ${PROJECT}."
+ if [ -n "${ASF_USERNAME}" ] && [ -n "${ASF_PASSWORD}" ]; then
+ # Ugly!
+ encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''')")
+ encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''')")
+ GIT_REPO="https://$encoded_username:$encoded_password@${asf_repo}"
+ else
+ GIT_REPO="https://${asf_repo}"
+ fi
+ else
+ echo "[INFO] clone will be of provided git repo."
+ fi
+ # N.B. we use the shared flag because the clone is short lived and if a local repo repo was
+ # given this will let us refer to objects there directly instead of hardlinks or copying.
+ # The option is silently ignored for non-local repositories. see the note on git help clone
+ # for the --shared option for details.
+ git clone --shared -b "${GIT_BRANCH}" -- "${GIT_REPO}" "${PROJECT}"
+ # If this was a host local git repo then add in an alterntes and remote that will
+ # work back on the host if the RM needs to do any post-processing steps, i.e. pushing the git tag
Review comment:
to be fair, it is a bit of black magic. enough explanation here already in case someone trips on it? or maybe I should expand the doc to show use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#discussion_r429421666
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
Review comment:
it's a nit, but yeah, that could help. I found it initially confusing because many git commands support a `--force` flag.
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
+ local asf_repo
+ if [ -d "${PROJECT}" ]; then
+ rm -rf "${PROJECT}"
+ fi
+
+ if [[ -z "${GIT_REPO}" ]]; then
+ asf_repo="gitbox.apache.org/repos/asf/${PROJECT}.git"
+ echo "[INFO] clone will be of the gitbox repo for ${PROJECT}."
+ if [ -n "${ASF_USERNAME}" ] && [ -n "${ASF_PASSWORD}" ]; then
+ # Ugly!
+ encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''')")
+ encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''')")
+ GIT_REPO="https://$encoded_username:$encoded_password@${asf_repo}"
+ else
+ GIT_REPO="https://${asf_repo}"
+ fi
+ else
+ echo "[INFO] clone will be of provided git repo."
+ fi
+ # N.B. we use the shared flag because the clone is short lived and if a local repo repo was
Review comment:
thank you!
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,40 @@ function configure_maven {
EOF
}
+# force a clone of the repo, optionally with auth details for pushing.
+function git_force_clone {
+ local asf_repo
+ if [ -d "${PROJECT}" ]; then
+ rm -rf "${PROJECT}"
+ fi
+
+ if [[ -z "${GIT_REPO}" ]]; then
+ asf_repo="gitbox.apache.org/repos/asf/${PROJECT}.git"
+ echo "[INFO] clone will be of the gitbox repo for ${PROJECT}."
+ if [ -n "${ASF_USERNAME}" ] && [ -n "${ASF_PASSWORD}" ]; then
+ # Ugly!
+ encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''')")
+ encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''')")
+ GIT_REPO="https://$encoded_username:$encoded_password@${asf_repo}"
+ else
+ GIT_REPO="https://${asf_repo}"
+ fi
+ else
+ echo "[INFO] clone will be of provided git repo."
+ fi
+ # N.B. we use the shared flag because the clone is short lived and if a local repo repo was
+ # given this will let us refer to objects there directly instead of hardlinks or copying.
+ # The option is silently ignored for non-local repositories. see the note on git help clone
+ # for the --shared option for details.
+ git clone --shared -b "${GIT_BRANCH}" -- "${GIT_REPO}" "${PROJECT}"
+ # If this was a host local git repo then add in an alterntes and remote that will
+ # work back on the host if the RM needs to do any post-processing steps, i.e. pushing the git tag
Review comment:
Reading it again, what you have here is sufficient to let me know that i could trip over a pot-hole. A `git-help` invocation that documents the feature you're using would be helpful, if you want to go the extra mile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#discussion_r429427677
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -389,6 +389,43 @@ function configure_maven {
EOF
}
+# clone of the repo, deleting anything that exists in the working directory named after the project.
+# optionally with auth details for pushing.
+function git_clone_overwrite {
+ local asf_repo
+ if [ -z "${PROJECT}" ] || [ "${PROJECT}" != "${PROJECT#/}" ]; then
+ error "Project name must be defined and not start with a '/'. PROJECT='${PROJECT}'"
+ fi
+ rm -rf "${PROJECT}"
Review comment:
I am a bit nervous here about malformed project names like "../.."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#discussion_r429419909
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -168,11 +172,65 @@ if [ -n "$JAVA" ]; then
JAVA_VOL=(--volume "$JAVA:/opt/hbase-java")
fi
+#TODO some debug output would be good here
+GIT_REPO_MOUNT=()
+if [ -n "${GIT_REPO}" ]; then
+ case "${GIT_REPO}" in
+ # skip the easy to identify remote protocols
+ ssh://*|git://*|http://*|https://*|ftp://*|ftps://*) ;;
+ # for sure local
+ /*)
+ GIT_REPO_MOUNT=(--mount "type=bind,src=${GIT_REPO},dst=/opt/hbase-repo")
+ echo "HOST_GIT_REPO=${GIT_REPO}" >> "${ENVFILE}"
+ GIT_REPO="/opt/hbase-repo"
+ ;;
+ # on the host but normally git wouldn't use the local optimization
+ file://*)
+ echo "[INFO] converted file:// git repo to a local path, which changes git to assume --local."
+ GIT_REPO_MOUNT=(--mount "type=bind,src=${GIT_REPO#file://},dst=/opt/hbase-repo")
+ echo "HOST_GIT_REPO=${GIT_REPO}" >> "${ENVFILE}"
+ GIT_REPO="/opt/hbase-repo"
+ ;;
+ # have to decide if it's a local path or the "scp-ish" remote
+ *)
Review comment:
unfortunately git supports a repo path that looks like an scp remote file path that doesn't fit that pattern. which means if it does not match we still have to do the wonky "is this local or scp" business.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#issuecomment-632893344
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
| -0 :warning: | shellcheck | 0m 3s | The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 1m 52s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1725/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1725 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 567374aacfb8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e1d7dc82ea |
| shellcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1725/2/artifact/yetus-general-check/output/diff-patch-shellcheck.txt |
| Max. process+thread count | 50 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1725/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#issuecomment-632894225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#issuecomment-629877190
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
| -0 :warning: | shellcheck | 0m 3s | The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 2m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1725/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1725 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 72d599c81e71 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 15627bb722 |
| shellcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1725/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt |
| Max. process+thread count | 48 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1725/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
busbey commented on pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#issuecomment-629875827
@mattf-apache mind taking a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #1725: HBASE-24297 release scripts should be able to use an existing project clone
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1725:
URL: https://github.com/apache/hbase/pull/1725#discussion_r428333751
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -71,6 +72,7 @@ Options:
-j [path] path to local JDK installation to use building. By default the script will
use openjdk8 installed in the docker image.
-p [project] project to build, such as 'hbase' or 'hbase-thirdparty'; defaults to $PROJECT env var
+ -r [repo] git repo to use for remote git operations. defaults to ASF gitbox for project.
Review comment:
Why this? To save on time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org