[GitHub] kristw opened a new pull request #5867: [bugfix] Fix slice width calculation in dashboard

[GitBox <gi...@apache.org>]

kristw opened a new pull request #5867: [bugfix] Fix slice width calculation in dashboard 
URL: https://github.com/apache/incubator-superset/pull/5867
 
 
   Previous fix (https://github.com/apache/incubator-superset/pull/5839) was incorrect. 
   It only works for slices that spans 1-2 columns, but compute less width than it should be for the slices than span >2 columns. 
   
   The previous formula did not take `GRID_GUTTER_SIZE` into account. A slice with `n` columns also contains `n-1` gutter. 
   
   The formula for width is updated to 
   ```js
   widthMultiple * columnWidth + (widthMultiple - 1) * GRID_GUTTER_SIZE - CHART_MARGIN
   ```
   
   @john-bodley @graceguo-supercat 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org