You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/09/10 03:36:34 UTC
[Impala-ASF-CR] Fix python2.6 itertools.count() usage
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11408
Change subject: Fix python2.6 itertools.count() usage
......................................................................
Fix python2.6 itertools.count() usage
In python 2.6, itertools.count() can't take
keyword arguments.
Change-Id: I979e532101c9f0b76b149f80ad9aa390edd3f646
---
M tests/metadata/test_ddl.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/11408/1
--
To view, visit http://gerrit.cloudera.org:8080/11408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I979e532101c9f0b76b149f80ad9aa390edd3f646
Gerrit-Change-Number: 11408
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] Fix python2.6 itertools.count() usage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11408 )
Change subject: Fix python2.6 itertools.count() usage
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/625/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I979e532101c9f0b76b149f80ad9aa390edd3f646
Gerrit-Change-Number: 11408
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 04:11:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix python2.6 itertools.count() usage
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11408 )
Change subject: Fix python2.6 itertools.count() usage
......................................................................
Fix python2.6 itertools.count() usage
In python 2.6, itertools.count() can't take
keyword arguments.
Change-Id: I979e532101c9f0b76b149f80ad9aa390edd3f646
Reviewed-on: http://gerrit.cloudera.org:8080/11408
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M tests/metadata/test_ddl.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I979e532101c9f0b76b149f80ad9aa390edd3f646
Gerrit-Change-Number: 11408
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] Fix python2.6 itertools.count() usage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11408 )
Change subject: Fix python2.6 itertools.count() usage
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3135/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I979e532101c9f0b76b149f80ad9aa390edd3f646
Gerrit-Change-Number: 11408
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 03:37:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix python2.6 itertools.count() usage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11408 )
Change subject: Fix python2.6 itertools.count() usage
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I979e532101c9f0b76b149f80ad9aa390edd3f646
Gerrit-Change-Number: 11408
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 07:06:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix python2.6 itertools.count() usage
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11408 )
Change subject: Fix python2.6 itertools.count() usage
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I979e532101c9f0b76b149f80ad9aa390edd3f646
Gerrit-Change-Number: 11408
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Sep 2018 15:35:40 +0000
Gerrit-HasComments: No