You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "Maxxx873 (via GitHub)" <gi...@apache.org> on 2023/06/09 16:59:06 UTC
[GitHub] [james-project] Maxxx873 opened a new pull request, #1587: JAMES-2148 create domain mappings via the CLI
Maxxx873 opened a new pull request, #1587:
URL: https://github.com/apache/james-project/pull/1587
JAMES-2148 create domain mappings via the CLI:
* added getDomainMappings method in RecipientRewriteTableManagementMBean and RecipientRewriteTableManagement;
* added the following commands in CmdType:
- AddDomainMapping,
- RemoveDomainMapping,
- ListDomainMappings;
* added the corresponding tests in CmdTypeTest;
* added the code for handling commands in ServerCmd;
* added the corresponding tests in ServerCmdTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1587: JAMES-2148 create domain mappings via the CLI
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1587:
URL: https://github.com/apache/james-project/pull/1587#discussion_r1225986732
##########
server/apps/cli/src/test/java/org/apache/james/cli/ServerCmdTest.java:
##########
@@ -19,34 +19,14 @@
package org.apache.james.cli;
-import static org.assertj.core.api.Assertions.assertThat;
Review Comment:
Those import reorderare not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Maxxx873 commented on pull request #1587: JAMES-2148 create domain mappings via the CLI
Posted by "Maxxx873 (via GitHub)" <gi...@apache.org>.
Maxxx873 commented on PR #1587:
URL: https://github.com/apache/james-project/pull/1587#issuecomment-1586779142
> Nice little contribution, thanks and welcome :)
I like this project and it's interesting to follow its development. I hope to contribute to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Maxxx873 commented on pull request #1587: JAMES-2148 create domain mappings via the CLI
Posted by "Maxxx873 (via GitHub)" <gi...@apache.org>.
Maxxx873 commented on PR #1587:
URL: https://github.com/apache/james-project/pull/1587#issuecomment-1586841264
> Hi, Thank you for your contribution <3 It would be even greater if you could add some docs in `src/site/markdown/server/manage-cli.md`.
Thanks for the comment! I'll be sure to update the documentation a bit later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1587: JAMES-2148 create domain mappings via the CLI
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #1587:
URL: https://github.com/apache/james-project/pull/1587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1587: JAMES-2148 create domain mappings via the CLI
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1587:
URL: https://github.com/apache/james-project/pull/1587#issuecomment-1588409079
Thank you for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org