You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org> on 2018/10/03 07:19:41 UTC

[Impala-ASF-CR] IMPALA-7484: Unrecognized hints are interpreted as straight join

Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11568 )

Change subject: IMPALA-7484: Unrecognized hints are interpreted as straight_join
......................................................................

IMPALA-7484: Unrecognized hints are interpreted as straight_join

Call to setIsStraightJoin() is outside else clause in SelectList.java
causing even unrecognized hints to be interpreted as straight_joins.
Moved it into an else. Now it will be set only if the hint is
a straight_join.

Testing: Added two test cases to TestSelectListHints.
1) To assert straight_join is not set when hint is unrecognized and
2) To assert it is properly set when hint is indeed a straigh_join.

Change-Id: Icf600ebbfefc7398e0896df143a0ab91545cae04
---
M fe/src/main/java/org/apache/impala/analysis/SelectList.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
2 files changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/11568/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf600ebbfefc7398e0896df143a0ab91545cae04
Gerrit-Change-Number: 11568
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>