[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #634: Ballista: Implement scalable distributed joins

[GitBox <gi...@apache.org>]

Dandandan commented on a change in pull request #634:
URL: https://github.com/apache/arrow-datafusion/pull/634#discussion_r663374937



##########
File path: ballista/rust/core/src/utils.rs
##########
@@ -227,16 +227,7 @@ fn build_exec_plan_diagram(
 
 /// Create a DataFusion context that is compatible with Ballista
 pub fn create_datafusion_context() -> ExecutionContext {
-    // remove Repartition rule because that isn't supported yet
-    let rules: Vec<Arc<dyn PhysicalOptimizerRule + Send + Sync>> = vec![
-        Arc::new(CoalesceBatches::new()),
-        Arc::new(AddCoalescePartitionsExec::new()),
-    ];
-    let config = ExecutionConfig::new()
-        .with_concurrency(1)
-        .with_repartition_joins(false)
-        .with_repartition_aggregations(false)
-        .with_physical_optimizer_rules(rules);
+    let config = ExecutionConfig::new().with_concurrency(2); // TODO: this is hack to enable partitioned joins

Review comment:
       What is the idea here for later? I guess the repartitioning needs to be applied with `concurrency=1` too to avoid inefficient plans?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org