[jira] [Comment Edited] (HBASE-20297) Remove Logger#isErrorEnabled check

["Yuki Tawara (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417635#comment-16417635 ] 

Yuki Tawara edited comment on HBASE-20297 at 3/28/18 4:02 PM:
--------------------------------------------------------------

Thanks for your help, stack. I can make transitions.
Could you review the patch?

 


was (Author: yktawara):
Thanks for your help, stack. I can make transitions.

Could you review the patch?

 

> Remove Logger#isErrorEnabled check
> ----------------------------------
>
>                 Key: HBASE-20297
>                 URL: https://issues.apache.org/jira/browse/HBASE-20297
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Yuki Tawara
>            Assignee: Yuki Tawara
>            Priority: Trivial
>         Attachments: HBASE-20297.master.001.patch
>
>
> Logger#isErrorEnabled check is unnecessary, so it should be removed.
> I greped the code base and found 3 occurrences.
> (The checks in Logging.scala seem necessary.)
> {noformat}
> ./hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java: if (LOG.isErrorEnabled()) LOG.error("Caught error", t);
> ./hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/Logging.scala: if (log.isErrorEnabled) log.error(msg)
> ./hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/Logging.scala: if (log.isErrorEnabled) log.error(msg, throwable)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)