You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Joe Bohn <jo...@earthlink.net> on 2009/01/27 17:15:18 UTC
Re: svn commit: r738106 - in /geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view:
ca/confirmCA.jsp ca/setupCA.jsp ca/unlockCA.jsp keystore/confirmKey.jsp keystore/unlockKey.jsp
keystore/unlockKeystore.jsp
Heh .. you beat me to the check-in.
I have a number of additional changes from get->post (hopefully I hit
all the remaining references). I'm building and running tests now to
make sure I didn't make any typos. When that finishes I'll update to
get your changes and merge anything necessary before I check in.
This is just a heads-up to let you know that I'm making some of the same
changes with a check-in soon.
Joe
dwoods@apache.org wrote:
> Author: dwoods
> Date: Tue Jan 27 14:58:28 2009
> New Revision: 738106
>
> URL: http://svn.apache.org/viewvc?rev=738106&view=rev
> Log:
> part 3 of more cleanup of old forms (see Rev735746 for part 2)
>
> Modified:
> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/confirmCA.jsp
> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/setupCA.jsp
> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/unlockCA.jsp
> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/confirmKey.jsp
> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKey.jsp
> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKeystore.jsp
>
> Modified: geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/confirmCA.jsp
> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/confirmCA.jsp?rev=738106&r1=738105&r2=738106&view=diff
> ==============================================================================
> --- geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/confirmCA.jsp (original)
> +++ geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/confirmCA.jsp Tue Jan 27 14:58:28 2009
> @@ -26,7 +26,7 @@
>
> <jsp:include page="_header.jsp" />
>
> -<form name="<portlet:namespace/>confirmCAForm" action="<portlet:actionURL/>">
> +<form name="<portlet:namespace/>confirmCAForm" action="<portlet:actionURL/>" method="POST">
> <input type="hidden" name="mode" value="confirmCA-after" />
> <table border="0">
> <tr>
>
> Modified: geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/setupCA.jsp
> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/setupCA.jsp?rev=738106&r1=738105&r2=738106&view=diff
> ==============================================================================
> --- geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/setupCA.jsp (original)
> +++ geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/setupCA.jsp Tue Jan 27 14:58:28 2009
> @@ -44,8 +44,8 @@
> alert('validFrom date must be before validTo date');
> return false;
> }
> - // Check if password and confirm password match
> - if(document.forms[<portlet:namespace/>formName].password.value != document.forms[<portlet:namespace/>formName].confirm.value) {
> + // Check if password and confirmPassword match
> + if(document.forms[<portlet:namespace/>formName].password.value != document.forms[<portlet:namespace/>formName].confirmPassword.value) {
> alert('password and confirm password do not match.');
> document.forms[<portlet:namespace/>formName].password.focus();
> return false;
> @@ -143,7 +143,7 @@
> <tr>
> <th align="right"><fmt:message key="consolebase.common.confirmPassword"/>:</th>
> <td>
> - <input type="password" name="confirm" size="20" maxlength="200"/>
> + <input type="password" name="confirmPassword" size="20" maxlength="200"/>
> </td>
> </tr>
> <tr><td> </td></tr>
>
> Modified: geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/unlockCA.jsp
> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/unlockCA.jsp?rev=738106&r1=738105&r2=738106&view=diff
> ==============================================================================
> --- geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/unlockCA.jsp (original)
> +++ geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/unlockCA.jsp Tue Jan 27 14:58:28 2009
> @@ -38,7 +38,7 @@
>
> <jsp:include page="_header.jsp" />
>
> -<form name="<portlet:namespace/>UnlockCAForm" action="<portlet:actionURL/>">
> +<form name="<portlet:namespace/>UnlockCAForm" action="<portlet:actionURL/>" method="POST">
> <input type="hidden" name="mode" value="unlockCA-after" />
> <b><fmt:message key="ca.unlockCA.enterCAPrivateKeyPassword"/>:</b>
> <input type="password" name="password" size="20" maxlength="200" />
>
> Modified: geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/confirmKey.jsp
> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/confirmKey.jsp?rev=738106&r1=738105&r2=738106&view=diff
> ==============================================================================
> --- geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/confirmKey.jsp (original)
> +++ geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/confirmKey.jsp Tue Jan 27 14:58:28 2009
> @@ -23,7 +23,7 @@
>
> <p><fmt:message key="keystore.confirmKey.title"/></p>
>
> -<form name="<portlet:namespace/>KeystoreForm" action="<portlet:actionURL/>">
> +<form name="<portlet:namespace/>KeystoreForm" action="<portlet:actionURL/>" method="POST">
> <input type="hidden" name="mode" value="confirmKey-after" />
> <input type="hidden" name="keystore" value="${keystore}" />
> <input type="hidden" name="alias" value="${alias}" />
>
> Modified: geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKey.jsp
> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKey.jsp?rev=738106&r1=738105&r2=738106&view=diff
> ==============================================================================
> --- geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKey.jsp (original)
> +++ geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKey.jsp Tue Jan 27 14:58:28 2009
> @@ -28,7 +28,7 @@
>
> <jsp:include page="_header.jsp" />
>
> -<form name="<portlet:namespace/>KeystoreForm" action="<portlet:actionURL/>">
> +<form name="<portlet:namespace/>KeystoreForm" action="<portlet:actionURL/>" method="POST">
> <input type="hidden" name="keystore" value="${keystore}" />
> <input type="hidden" name="password" value="${password}" />
> <input type="hidden" name="mode" value="unlockKey-after" />
>
> Modified: geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKeystore.jsp
> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKeystore.jsp?rev=738106&r1=738105&r2=738106&view=diff
> ==============================================================================
> --- geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKeystore.jsp (original)
> +++ geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKeystore.jsp Tue Jan 27 14:58:28 2009
> @@ -26,7 +26,7 @@
>
> <jsp:include page="_header.jsp" />
>
> -<form name="<portlet:namespace/>KeystoreForm" action="<portlet:actionURL/>">
> +<form name="<portlet:namespace/>KeystoreForm" action="<portlet:actionURL/>" method="POST">
> <input type="hidden" name="keystore" value="${keystore}" />
> <input type="hidden" name="mode" value="${mode}-after" />
> <b><fmt:message key="keystore.unlockKeystore.enterKeystorePassword"/>:</b>
>
>
>
Re: svn commit: r738106 - in /geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view:
ca/confirmCA.jsp ca/setupCA.jsp ca/unlockCA.jsp keystore/confirmKey.jsp keystore/unlockKey.jsp
keystore/unlockKeystore.jsp
Posted by Donald Woods <dw...@apache.org>.
OK, thanks. That should be the last form updates I have, unless I find
another instance where a password field doesn't use "password" as part
of the value name....
-Donald
Joe Bohn wrote:
> Heh .. you beat me to the check-in.
>
> I have a number of additional changes from get->post (hopefully I hit
> all the remaining references). I'm building and running tests now to
> make sure I didn't make any typos. When that finishes I'll update to
> get your changes and merge anything necessary before I check in.
>
> This is just a heads-up to let you know that I'm making some of the same
> changes with a check-in soon.
>
> Joe
>
>
> dwoods@apache.org wrote:
>> Author: dwoods
>> Date: Tue Jan 27 14:58:28 2009
>> New Revision: 738106
>>
>> URL: http://svn.apache.org/viewvc?rev=738106&view=rev
>> Log:
>> part 3 of more cleanup of old forms (see Rev735746 for part 2)
>>
>> Modified:
>>
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/confirmCA.jsp
>>
>>
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/setupCA.jsp
>>
>>
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/unlockCA.jsp
>>
>>
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/confirmKey.jsp
>>
>>
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKey.jsp
>>
>>
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKeystore.jsp
>>
>>
>> Modified:
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/confirmCA.jsp
>>
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/confirmCA.jsp?rev=738106&r1=738105&r2=738106&view=diff
>>
>> ==============================================================================
>>
>> ---
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/confirmCA.jsp
>> (original)
>> +++
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/confirmCA.jsp
>> Tue Jan 27 14:58:28 2009
>> @@ -26,7 +26,7 @@
>>
>> <jsp:include page="_header.jsp" />
>>
>> -<form name="<portlet:namespace/>confirmCAForm"
>> action="<portlet:actionURL/>">
>> +<form name="<portlet:namespace/>confirmCAForm"
>> action="<portlet:actionURL/>" method="POST">
>> <input type="hidden" name="mode" value="confirmCA-after" />
>> <table border="0">
>> <tr>
>>
>> Modified:
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/setupCA.jsp
>>
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/setupCA.jsp?rev=738106&r1=738105&r2=738106&view=diff
>>
>> ==============================================================================
>>
>> ---
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/setupCA.jsp
>> (original)
>> +++
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/setupCA.jsp
>> Tue Jan 27 14:58:28 2009
>> @@ -44,8 +44,8 @@
>> alert('validFrom date must be before validTo date');
>> return false;
>> }
>> - // Check if password and confirm password match
>> - if(document.forms[<portlet:namespace/>formName].password.value !=
>> document.forms[<portlet:namespace/>formName].confirm.value) {
>> + // Check if password and confirmPassword match
>> + if(document.forms[<portlet:namespace/>formName].password.value !=
>> document.forms[<portlet:namespace/>formName].confirmPassword.value) {
>> alert('password and confirm password do not match.');
>> document.forms[<portlet:namespace/>formName].password.focus();
>> return false;
>> @@ -143,7 +143,7 @@
>> <tr>
>> <th align="right"><fmt:message
>> key="consolebase.common.confirmPassword"/>:</th>
>> <td>
>> - <input type="password" name="confirm" size="20"
>> maxlength="200"/>
>> + <input type="password" name="confirmPassword"
>> size="20" maxlength="200"/>
>> </td>
>> </tr>
>> <tr><td> </td></tr>
>>
>> Modified:
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/unlockCA.jsp
>>
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/unlockCA.jsp?rev=738106&r1=738105&r2=738106&view=diff
>>
>> ==============================================================================
>>
>> ---
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/unlockCA.jsp
>> (original)
>> +++
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/ca/unlockCA.jsp
>> Tue Jan 27 14:58:28 2009
>> @@ -38,7 +38,7 @@
>>
>> <jsp:include page="_header.jsp" />
>>
>> -<form name="<portlet:namespace/>UnlockCAForm"
>> action="<portlet:actionURL/>">
>> +<form name="<portlet:namespace/>UnlockCAForm"
>> action="<portlet:actionURL/>" method="POST">
>> <input type="hidden" name="mode" value="unlockCA-after" />
>> <b><fmt:message key="ca.unlockCA.enterCAPrivateKeyPassword"/>:</b>
>> <input type="password" name="password" size="20" maxlength="200" />
>>
>> Modified:
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/confirmKey.jsp
>>
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/confirmKey.jsp?rev=738106&r1=738105&r2=738106&view=diff
>>
>> ==============================================================================
>>
>> ---
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/confirmKey.jsp
>> (original)
>> +++
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/confirmKey.jsp
>> Tue Jan 27 14:58:28 2009
>> @@ -23,7 +23,7 @@
>>
>> <p><fmt:message key="keystore.confirmKey.title"/></p>
>>
>> -<form name="<portlet:namespace/>KeystoreForm"
>> action="<portlet:actionURL/>">
>> +<form name="<portlet:namespace/>KeystoreForm"
>> action="<portlet:actionURL/>" method="POST">
>> <input type="hidden" name="mode" value="confirmKey-after" />
>> <input type="hidden" name="keystore" value="${keystore}" />
>> <input type="hidden" name="alias" value="${alias}" />
>>
>> Modified:
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKey.jsp
>>
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKey.jsp?rev=738106&r1=738105&r2=738106&view=diff
>>
>> ==============================================================================
>>
>> ---
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKey.jsp
>> (original)
>> +++
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKey.jsp
>> Tue Jan 27 14:58:28 2009
>> @@ -28,7 +28,7 @@
>>
>> <jsp:include page="_header.jsp" />
>>
>> -<form name="<portlet:namespace/>KeystoreForm"
>> action="<portlet:actionURL/>">
>> +<form name="<portlet:namespace/>KeystoreForm"
>> action="<portlet:actionURL/>" method="POST">
>> <input type="hidden" name="keystore" value="${keystore}" />
>> <input type="hidden" name="password" value="${password}" />
>> <input type="hidden" name="mode" value="unlockKey-after" />
>>
>> Modified:
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKeystore.jsp
>>
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKeystore.jsp?rev=738106&r1=738105&r2=738106&view=diff
>>
>> ==============================================================================
>>
>> ---
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKeystore.jsp
>> (original)
>> +++
>> geronimo/server/branches/2.1/plugins/console/console-base-portlets/src/main/webapp/WEB-INF/view/keystore/unlockKeystore.jsp
>> Tue Jan 27 14:58:28 2009
>> @@ -26,7 +26,7 @@
>>
>> <jsp:include page="_header.jsp" />
>>
>> -<form name="<portlet:namespace/>KeystoreForm"
>> action="<portlet:actionURL/>">
>> +<form name="<portlet:namespace/>KeystoreForm"
>> action="<portlet:actionURL/>" method="POST">
>> <input type="hidden" name="keystore" value="${keystore}" />
>> <input type="hidden" name="mode" value="${mode}-after" />
>> <b><fmt:message
>> key="keystore.unlockKeystore.enterKeystorePassword"/>:</b>
>>
>>
>>
>
>