You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/17 20:22:29 UTC

[GitHub] [geode] sabbey37 commented on a change in pull request #6150: GEODE-9045: rename redis properties and reword error messages

sabbey37 commented on a change in pull request #6150:
URL: https://github.com/apache/geode/pull/6150#discussion_r596349636



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/SSLTest.java
##########
@@ -41,8 +41,8 @@
   @ClassRule
   public static ServerStarterRule sslEnabledServer = new ServerStarterRule()
       .withSSL("server", true, true)
-      .withProperty("redis-bind-address", "localhost")
-      .withProperty("redis-port", "11211")
+      .withProperty("compatible-with-redis-bind-address", "localhost")
+      .withProperty("compatible-with-redis-port", "11211")
       .withProperty("redis-enabled", "true")

Review comment:
       Is the `redis-enabled` property ok or should that be changed as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org