[GitHub] [tinkerpop] spmallette commented on a diff in pull request #1788: Dev Environments: Dockerize Testing for JavaScript and .NET & Updates for Go

[GitBox <gi...@apache.org>]

spmallette commented on code in PR #1788:
URL: https://github.com/apache/tinkerpop/pull/1788#discussion_r959777302


##########
docker/gremlin-server/gremlin-server-integration.yaml:
##########
@@ -18,13 +18,15 @@
 host: 0.0.0.0
 port: 45940
 evaluationTimeout: 30000
+channelizer: org.apache.tinkerpop.gremlin.server.channel.WsAndHttpChannelizer
 graphs: {
-  graph: conf/tinkergraph-empty.properties,
-  classic: conf/tinkergraph-empty.properties,
-  modern: conf/tinkergraph-empty.properties,
-  crew: conf/tinkergraph-empty.properties,
-  grateful: conf/tinkergraph-empty.properties,
-  sink: conf/tinkergraph-empty.properties
+  graph: scripts/tinkergraph-empty.properties,

Review Comment:
   to avoid the confusion here, perhaps `scripts/tinkergraph-empty.properties` should be renamed and kept in `conf/`. maybe call it `conf/tinkergraph-service.properties`. a pity we need `INTEGER` ID manager in there for testing but i guess it's ok. 
   
   historically, i think this file was kept separately to avoid it being added to the zip file binary packaging for releases. naming it `tinkergraph-service.properties` might allow it to be ok to be included as a test file as it would allow the `call()` step to be used (not sure I remember how that is setup now). only trouble is that `INTEGER` is not a good default for distribution, but maybe that's ok. I forget why `INTEGER` was needed but i'm almost sure that if you change that, tests will start to fail.
   
   in any case, i think we should get all the graph configs pointed at `conf/` and not have this weird exception. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org