You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2008/10/07 23:34:44 UTC

[jira] Commented: (THRIFT-109) Python unit tests should use self.assert*

    [ https://issues.apache.org/jira/browse/THRIFT-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637660#action_12637660 ] 

David Reiss commented on THRIFT-109:
------------------------------------

I don't think assertAlmostEqual is correct here because we are checking against a timeout (though I'm not sure that these tests are correct).

Also, why did you reverse the order in the comparisons?

> Python unit tests should use self.assert*
> -----------------------------------------
>
>                 Key: THRIFT-109
>                 URL: https://issues.apache.org/jira/browse/THRIFT-109
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Test Suite
>            Reporter: Esteve Fernandez
>            Priority: Minor
>         Attachments: py_unittests.patch
>
>
> In some of tests in the current testsuite for Python use, "assert EXPR" instead of the standard self.assert* methods. It's recommended using these methods as they give more information in case an assertion fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.