[jira] Commented: (DERBY-4509) Convert autoincrement.sql to JUnit

["Kathey Marsden (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841544#action_12841544 ] 

Kathey Marsden commented on DERBY-4509:
---------------------------------------

I spoke with Jayaram on the phone and IRC about the Autoincrementrevised.txt patch.
The main thing was that he needs to review the new test and compare it to  autoincrement.out and make sure everything is included. I put suggested he put it in the same general order  and copy the comments exactly so we don't miss anything and it is easy to check.   Besides that, I had the following  details:
- suite.addTest(OrderByAndOffsetFetchInSubqueries.suite()); seems to be missing now from lang/_Suite.java
- autoincrement.sql is still in derbylang.runall and needs to be removed.
- test name in AutoIncrementTest in licence header should be changed from SimpleTest
- use local variables for rs and expectedRows in each fixture instead of fields.  Fields tend to leak memory in Junit tests.
- make sure lock_table queries are being executed as they were in autoincrement.sql. The view creation is there but I didn't see the queries to check for locking behavior.


> Convert autoincrement.sql to JUnit
> ----------------------------------
>
>                 Key: DERBY-4509
>                 URL: https://issues.apache.org/jira/browse/DERBY-4509
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>         Environment: Apache Derby
>            Reporter: Jayaram Subramanian
>            Assignee: Jayaram Subramanian
>            Priority: Minor
>         Attachments: AutoIncrementDO-NOT_COMMIT_diff.txt, AutoIncrementDO_NOT_COMMIT_diff.txt, AutoIncrementDO_NOT_COMMIT_diff.txt, AutoIncrementrevised.txt, jira4509.txt, jira4509feb4.txt, jira4509feb4stat.txt, jira4509stat.txt, statrevised.txt
>
>
> The task is to convert existing autoincrement.sql to JUnit

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.