You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hivemind.apache.org by "James Carman (JIRA)" <hi...@jakarta.apache.org> on 2005/03/28 03:05:16 UTC
[jira] Created: (HIVEMIND-103) Core service implementations which implement RegistryShutdownListener are not notified for primitive and singleton service models
Core service implementations which implement RegistryShutdownListener are not notified for primitive and singleton service models
---------------------------------------------------------------------------------------------------------------------------------
Key: HIVEMIND-103
URL: http://issues.apache.org/jira/browse/HIVEMIND-103
Project: HiveMind
Type: Bug
Components: framework
Versions: 1.1
Reporter: James Carman
Assigned to: James Carman
Fix For: 1.1
Per the documentation, if a core service implementation object implements RegistryShutdownListener, it is supposed to automatically be added as a listener to the ShutdownCoordinator. This is only supposed to be true for the primitive and singleton service models, but it's not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org
RE: [jira] Commented: (HIVEMIND-103) Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
Posted by James Carman <ja...@carmanconsulting.com>.
So, are we okay with leaving these changes in and allowing service
implementations to automatically receive registry shutdown events, if they
implement RegistryShutdownListener?
-----Original Message-----
From: Howard Lewis Ship [mailto:hlship@gmail.com]
Sent: Monday, March 28, 2005 5:47 PM
To: hivemind-dev@jakarta.apache.org
Subject: Re: [jira] Commented: (HIVEMIND-103) Core service implementations
which implement RegistryShutdownListener are not notified for primitive,
singleton, and pooled service models
I've been thinking of adding one or two "special cases" to HiveMind for
things like the ShutdownCoordinator; basically, a way to programatically
provide an instance as the core service implementation of a well known
service (such as hivemind.ShutdownCoordinator).
On Tue, 29 Mar 2005 00:42:17 +0200 (CEST), James Carman (JIRA)
<hi...@jakarta.apache.org> wrote:
> [
> http://issues.apache.org/jira/browse/HIVEMIND-103?page=comments#action
> _61681 ]
>
> James Carman commented on HIVEMIND-103:
> ---------------------------------------
>
> I added a test case which showed exactly what you said. You were
> correct. It was calling registryDidShutdown() twice in all cases. I
> added code to the ShutdownCoordinatorImpl to verify that it's not
> calling registryDidShutdown() on the same exact instance more than
> once (it uses the identity hashcode so that objects which aren't
> playing nice can't mess things up). Also, I found out there there are
> actually TWO ShutdownCoordinatorImpl objects created at runtime. One
> which is exposed as a service and one that's used internally by the
> infrastructure. I changed my code to make sure I was adding the
> implementation objects to the service version rather than the
> infrastructure version, as this is most likely where service
> implementations will add themselves if they do so.
>
> > Core service implementations which implement
> > RegistryShutdownListener are not notified for primitive, singleton, and
pooled service models
> >
----------------------------------------------------------------------------
--------------------------------------------------------------
> >
> > Key: HIVEMIND-103
> > URL: http://issues.apache.org/jira/browse/HIVEMIND-103
> > Project: HiveMind
> > Type: Bug
> > Components: framework
> > Versions: 1.1
> > Reporter: James Carman
> > Assignee: James Carman
> > Fix For: 1.1
>
> >
> > Per the documentation, if a core service implementation object
> > implements RegistryShutdownListener, it is supposed to automatically
> > be added as a listener to the ShutdownCoordinator. This is only
> > supposed to be true for the primitive, singleton, and pooled service
> > models, but it's not happening.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> If you want more information on JIRA, or have a bug to report see:
> http://www.atlassian.com/software/jira
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org
>
>
--
Howard M. Lewis Ship
Independent J2EE / Open-Source Java Consultant
Creator, Jakarta Tapestry
Creator, Jakarta HiveMind
Professional Tapestry training, mentoring, support
and project work. http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org
Re: [jira] Commented: (HIVEMIND-103) Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
Posted by Howard Lewis Ship <hl...@gmail.com>.
I've been thinking of adding one or two "special cases" to HiveMind
for things like the ShutdownCoordinator; basically, a way to
programatically provide an instance as the core service implementation
of a well known service (such as hivemind.ShutdownCoordinator).
On Tue, 29 Mar 2005 00:42:17 +0200 (CEST), James Carman (JIRA)
<hi...@jakarta.apache.org> wrote:
> [ http://issues.apache.org/jira/browse/HIVEMIND-103?page=comments#action_61681 ]
>
> James Carman commented on HIVEMIND-103:
> ---------------------------------------
>
> I added a test case which showed exactly what you said. You were correct. It was calling registryDidShutdown() twice in all cases. I added code to the ShutdownCoordinatorImpl to verify that it's not calling registryDidShutdown() on the same exact instance more than once (it uses the identity hashcode so that objects which aren't playing nice can't mess things up). Also, I found out there there are actually TWO ShutdownCoordinatorImpl objects created at runtime. One which is exposed as a service and one that's used internally by the infrastructure. I changed my code to make sure I was adding the implementation objects to the service version rather than the infrastructure version, as this is most likely where service implementations will add themselves if they do so.
>
> > Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
> > ------------------------------------------------------------------------------------------------------------------------------------------
> >
> > Key: HIVEMIND-103
> > URL: http://issues.apache.org/jira/browse/HIVEMIND-103
> > Project: HiveMind
> > Type: Bug
> > Components: framework
> > Versions: 1.1
> > Reporter: James Carman
> > Assignee: James Carman
> > Fix For: 1.1
>
> >
> > Per the documentation, if a core service implementation object implements RegistryShutdownListener, it is supposed to automatically be added as a listener to the ShutdownCoordinator. This is only supposed to be true for the primitive, singleton, and pooled service models, but it's not happening.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> If you want more information on JIRA, or have a bug to report see:
> http://www.atlassian.com/software/jira
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org
>
>
--
Howard M. Lewis Ship
Independent J2EE / Open-Source Java Consultant
Creator, Jakarta Tapestry
Creator, Jakarta HiveMind
Professional Tapestry training, mentoring, support
and project work. http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org
[jira] Updated: (HIVEMIND-103) Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
Posted by "James Carman (JIRA)" <hi...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/HIVEMIND-103?page=history ]
James Carman updated HIVEMIND-103:
----------------------------------
Summary: Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models (was: Core service implementations which implement RegistryShutdownListener are not notified for primitive and singleton service models)
Description: Per the documentation, if a core service implementation object implements RegistryShutdownListener, it is supposed to automatically be added as a listener to the ShutdownCoordinator. This is only supposed to be true for the primitive, singleton, and pooled service models, but it's not happening. (was: Per the documentation, if a core service implementation object implements RegistryShutdownListener, it is supposed to automatically be added as a listener to the ShutdownCoordinator. This is only supposed to be true for the primitive and singleton service models, but it's not happening.)
This should include the pooled service model, also.
> Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVEMIND-103
> URL: http://issues.apache.org/jira/browse/HIVEMIND-103
> Project: HiveMind
> Type: Bug
> Components: framework
> Versions: 1.1
> Reporter: James Carman
> Assignee: James Carman
> Fix For: 1.1
>
> Per the documentation, if a core service implementation object implements RegistryShutdownListener, it is supposed to automatically be added as a listener to the ShutdownCoordinator. This is only supposed to be true for the primitive, singleton, and pooled service models, but it's not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org
[jira] Resolved: (HIVEMIND-103) Core service implementations which implement RegistryShutdownListener are not notified for primitive and singleton service models
Posted by "James Carman (JIRA)" <hi...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/HIVEMIND-103?page=history ]
James Carman resolved HIVEMIND-103:
-----------------------------------
Resolution: Fixed
The test cases which illustrate this bug and the corresponding fixes have been checked into CVS.
> Core service implementations which implement RegistryShutdownListener are not notified for primitive and singleton service models
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVEMIND-103
> URL: http://issues.apache.org/jira/browse/HIVEMIND-103
> Project: HiveMind
> Type: Bug
> Components: framework
> Versions: 1.1
> Reporter: James Carman
> Assignee: James Carman
> Fix For: 1.1
>
> Per the documentation, if a core service implementation object implements RegistryShutdownListener, it is supposed to automatically be added as a listener to the ShutdownCoordinator. This is only supposed to be true for the primitive and singleton service models, but it's not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org
[jira] Closed: (HIVEMIND-103) Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
Posted by "James Carman (JIRA)" <hi...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/HIVEMIND-103?page=all ]
James Carman closed HIVEMIND-103:
---------------------------------
> Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVEMIND-103
> URL: http://issues.apache.org/jira/browse/HIVEMIND-103
> Project: HiveMind
> Type: Bug
> Components: framework
> Versions: 1.1
> Reporter: James Carman
> Assignee: James Carman
> Fix For: 1.1
>
> Per the documentation, if a core service implementation object implements RegistryShutdownListener, it is supposed to automatically be added as a listener to the ShutdownCoordinator. This is only supposed to be true for the primitive, singleton, and pooled service models, but it's not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org
[jira] Commented: (HIVEMIND-103) Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
Posted by "Achim Hügen (JIRA)" <hi...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/HIVEMIND-103?page=comments#action_61625 ]
Achim Hügen commented on HIVEMIND-103:
--------------------------------------
I stumbled across this behaviour some days ago and decided that it's not a bug but a mattern of wrong assumptions and unclear documentation. The doc doesn't state explicitely that the registration is done automatically. Howard's testcase (TestShutdown) registers the services manually in shutdown.xml as event listeners.
I appreciate that change, but it will break some of the existing code if the registryDidShutdown is now called twice (that is what ShutdownCoordinatorImpl states). Have you prevented this case?
> Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVEMIND-103
> URL: http://issues.apache.org/jira/browse/HIVEMIND-103
> Project: HiveMind
> Type: Bug
> Components: framework
> Versions: 1.1
> Reporter: James Carman
> Assignee: James Carman
> Fix For: 1.1
>
> Per the documentation, if a core service implementation object implements RegistryShutdownListener, it is supposed to automatically be added as a listener to the ShutdownCoordinator. This is only supposed to be true for the primitive, singleton, and pooled service models, but it's not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org
[jira] Commented: (HIVEMIND-103) Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
Posted by "James Carman (JIRA)" <hi...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/HIVEMIND-103?page=comments#action_61681 ]
James Carman commented on HIVEMIND-103:
---------------------------------------
I added a test case which showed exactly what you said. You were correct. It was calling registryDidShutdown() twice in all cases. I added code to the ShutdownCoordinatorImpl to verify that it's not calling registryDidShutdown() on the same exact instance more than once (it uses the identity hashcode so that objects which aren't playing nice can't mess things up). Also, I found out there there are actually TWO ShutdownCoordinatorImpl objects created at runtime. One which is exposed as a service and one that's used internally by the infrastructure. I changed my code to make sure I was adding the implementation objects to the service version rather than the infrastructure version, as this is most likely where service implementations will add themselves if they do so.
> Core service implementations which implement RegistryShutdownListener are not notified for primitive, singleton, and pooled service models
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVEMIND-103
> URL: http://issues.apache.org/jira/browse/HIVEMIND-103
> Project: HiveMind
> Type: Bug
> Components: framework
> Versions: 1.1
> Reporter: James Carman
> Assignee: James Carman
> Fix For: 1.1
>
> Per the documentation, if a core service implementation object implements RegistryShutdownListener, it is supposed to automatically be added as a listener to the ShutdownCoordinator. This is only supposed to be true for the primitive, singleton, and pooled service models, but it's not happening.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org