You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/27 19:22:17 UTC
[GitHub] [ozone] tanvipenumudy opened a new pull request, #3358: HDDS-6662. Introduce a pluggable hashing module for OBSKeyPathLockStrategy
tanvipenumudy opened a new pull request, #3358:
URL: https://github.com/apache/ozone/pull/3358
## What changes were proposed in this pull request?
To introduce a pluggable hashing module: `OMHashCodeGenerator` interface which shall be used for the `OBSKeyPathLockStrategy` class locking logic.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6662
## How was this patch tested?
NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3358: HDDS-6662. Introduce a pluggable hashing module for OBSKeyPathLockStrategy
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on code in PR #3358:
URL: https://github.com/apache/ozone/pull/3358#discussion_r867639627
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/hashcodegenerator/OMHashCodeGenerator.java:
##########
@@ -0,0 +1,27 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.hadoop.ozone.om.hashcodegenerator;
+
+/**
+ * Interface for hash code generation implementations.
+ */
+public interface OMHashCodeGenerator {
+
+ int getHashCode(String resourceName);
Review Comment:
Please add javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3358: HDDS-6662. Introduce a pluggable hashing module for OBSKeyPathLockStrategy
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on code in PR #3358:
URL: https://github.com/apache/ozone/pull/3358#discussion_r867645369
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/hashcodegenerator/DefaultOMHashCodeGeneratorImpl.java:
##########
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.hadoop.ozone.om.hashcodegenerator;
+
+/**
+ * Implementation of OMHashCodeGenerator interface.
+ */
+public class DefaultOMHashCodeGeneratorImpl implements OMHashCodeGenerator {
Review Comment:
Please rename class `DefaultOMHashCodeGeneratorImpl` to -> `StringOMHashCodeGeneratorImpl` to reflect the implementation. Also, please update javadoc saying that "This implementation uses String hashcode function."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] tanvipenumudy commented on a diff in pull request #3358: HDDS-6662. Provide basic hash code generator for OBSKeyPathLockStrategy
Posted by GitBox <gi...@apache.org>.
tanvipenumudy commented on code in PR #3358:
URL: https://github.com/apache/ozone/pull/3358#discussion_r867700834
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/hashcodegenerator/DefaultOMHashCodeGeneratorImpl.java:
##########
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.hadoop.ozone.om.hashcodegenerator;
+
+/**
+ * Implementation of OMHashCodeGenerator interface.
+ */
+public class DefaultOMHashCodeGeneratorImpl implements OMHashCodeGenerator {
Review Comment:
I have made the changes, thank you!
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/lock/OBSKeyPathLockStrategy.java:
##########
@@ -31,6 +33,9 @@
*/
public class OBSKeyPathLockStrategy implements OzoneLockStrategy {
+ private OMHashCodeGenerator omHashCodeGenerator =
+ new DefaultOMHashCodeGeneratorImpl();
Review Comment:
I have added the TODO comment, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr merged pull request #3358: HDDS-6662. Provide basic hash code generator for OBSKeyPathLockStrategy
Posted by GitBox <gi...@apache.org>.
rakeshadr merged PR #3358:
URL: https://github.com/apache/ozone/pull/3358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] tanvipenumudy commented on a diff in pull request #3358: HDDS-6662. Provide basic hash code generator for OBSKeyPathLockStrategy
Posted by GitBox <gi...@apache.org>.
tanvipenumudy commented on code in PR #3358:
URL: https://github.com/apache/ozone/pull/3358#discussion_r867701235
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/hashcodegenerator/OMHashCodeGenerator.java:
##########
@@ -0,0 +1,27 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.hadoop.ozone.om.hashcodegenerator;
+
+/**
+ * Interface for hash code generation implementations.
+ */
+public interface OMHashCodeGenerator {
+
+ int getHashCode(String resourceName);
Review Comment:
I have added the Javadoc, thank you for the comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3358: HDDS-6662. Provide basic hash code generator for OBSKeyPathLockStrategy
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3358:
URL: https://github.com/apache/ozone/pull/3358#issuecomment-1193895726
@tanvipenumudy can you please resolve the conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3358: HDDS-6662. Introduce a pluggable hashing module for OBSKeyPathLockStrategy
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on code in PR #3358:
URL: https://github.com/apache/ozone/pull/3358#discussion_r867646595
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/lock/OBSKeyPathLockStrategy.java:
##########
@@ -31,6 +33,9 @@
*/
public class OBSKeyPathLockStrategy implements OzoneLockStrategy {
+ private OMHashCodeGenerator omHashCodeGenerator =
+ new DefaultOMHashCodeGeneratorImpl();
Review Comment:
Add a TODO saying that, "TODO: need to make this pluggable and allows users to configure the preferred hashcode generation mechanism."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org