You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/28 18:32:03 UTC

[GitHub] [arrow-datafusion] andygrove opened a new issue, #2640: Add subquery support in `datafusion-proto`

andygrove opened a new issue, #2640:
URL: https://github.com/apache/arrow-datafusion/issues/2640

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   Once https://github.com/apache/arrow-datafusion/pull/2639 is merged we should add support for serializing plans that contain subquery expressions.
   
   This will likely require breaking changes to the API because we currently have one API for `Expr` that optionally accepts a `FunctionRegistry` and one API for `LogicalPlan` that optionally accepts a `LogicalExtensionCodec`. With subquery support we have plans referencing expressions and expressions referencing plans, so these APIs will need to be combined somehow.
   
   **Describe the solution you'd like**
   TBD
   
   **Describe alternatives you've considered**
   None
   
   **Additional context**
   None
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] andygrove commented on issue #2640: Add subquery support in `datafusion-proto`

Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #2640:
URL: https://github.com/apache/arrow-datafusion/issues/2640#issuecomment-1142412941

   I have a PR up (https://github.com/apache/arrow-datafusion/pull/2670) with a proposal for the API part


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] liukun4515 commented on issue #2640: Add subquery support in `datafusion-proto`

Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #2640:
URL: https://github.com/apache/arrow-datafusion/issues/2640#issuecomment-1140717125

   also with that: https://github.com/apache/arrow-datafusion/issues/2338
   and https://github.com/andygrove/arrow-datafusion/blob/39c444835ddcb38cf1efeb4414fbb8ecd49ac020/datafusion/proto/src/to_proto.rs#L710


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on issue #2640: Add subquery support in `datafusion-proto`

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2640:
URL: https://github.com/apache/arrow-datafusion/issues/2640#issuecomment-1324912839

   Possibly duplicated by https://github.com/apache/arrow-datafusion/issues/2646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on issue #2640: Add subquery support in `datafusion-proto`

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2640:
URL: https://github.com/apache/arrow-datafusion/issues/2640#issuecomment-1140972567

   When we implement this feature, it might be worth considering a slightly more encapsulated API for serializing / deserializing plans, as described in  https://github.com/apache/arrow-datafusion/pull/2639#discussion_r884249631


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] liukun4515 commented on issue #2640: Add subquery support in `datafusion-proto`

Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #2640:
URL: https://github.com/apache/arrow-datafusion/issues/2640#issuecomment-1140716797

   feature of the subquery is needed in my system, I can figure out this issue.
   @andygrove 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org