Re: [PR] [SPARK-52544][SQL] Allow configuring Json datasource string length limit through SQLConf [spark]

["cdagraca (via GitHub)" <gi...@apache.org>]

cdagraca commented on code in PR #51235:
URL: https://github.com/apache/spark/pull/51235#discussion_r2263130135


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##########
@@ -4096,6 +4096,49 @@ abstract class JsonSuite
         Row("{null, bad json}"), Row("{[1,2,3], null}"))
     )
   }
+
+  test("Test JSON data source maxStringLen option") {
+    // Create a JSON string that is way longer than DEFAULT_MAX_STRING_LEN.
+    val longStringSize = StreamReadConstraints.DEFAULT_MAX_STRING_LEN * 10

Review Comment:
   If `* 10` works, `* 2` will - it's a test, not setting what the actual new max will be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org