Re: [PR] feat: display logged in as in the UserSettingsButton [airflow]

["aaron-wolmutt (via GitHub)" <gi...@apache.org>]

aaron-wolmutt commented on code in PR #58981:
URL: https://github.com/apache/airflow/pull/58981#discussion_r2583589358


##########
airflow-core/src/airflow/ui/src/layouts/Nav/UserSettingsButton.tsx:
##########
@@ -88,9 +90,19 @@ export const UserSettingsButton = ({ externalViews }: { readonly externalViews:
     <>
       <Menu.Root positioning={{ placement: "right" }}>
         <Menu.Trigger asChild>
-          <NavButton icon={FiUser} title={translate("user")} />
+          <NavButton icon={FiUser} title={translate("user.user")} />
         </Menu.Trigger>
         <Menu.Content>
+          {currentUser ? (
+            <Box borderBottom="1px solid" borderColor="border.muted" p={3}>
+              <Box color="fg.muted" fontSize="sm">
+                {translate("user.signedInAs")}
+              </Box>
+              <Box fontSize="md" fontWeight="semibold">
+                {currentUser.username}
+              </Box>
+            </Box>
+          ) : null}

Review Comment:
   Good point. I didn't get the warning when I committed earlier, the pre-commit hooks passed for me when I opened the PR, 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org