You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "RomanKa (Jira)" <ji...@apache.org> on 2020/01/17 09:54:00 UTC
[jira] [Commented] (TOMEE-2756) Typo in the DeploymentsResolver
causes excluding all URLs
[ https://issues.apache.org/jira/browse/TOMEE-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017858#comment-17017858 ]
RomanKa commented on TOMEE-2756:
--------------------------------
Goal is to exclude all jar files and only keep directories with class files. It's kind of hot deploy, I want to tell TomEE not to use build jars, but to use class files which are automatically compiled by the eclipse (we use it with embedded TomEE).
> Typo in the DeploymentsResolver causes excluding all URLs
> ---------------------------------------------------------
>
> Key: TOMEE-2756
> URL: https://issues.apache.org/jira/browse/TOMEE-2756
> Project: TomEE
> Issue Type: Bug
> Components: TomEE Core Server
> Affects Versions: 7.0.5
> Environment: Ubuntu 18.04, Embedded TomEE 7.0.5
> Reporter: RomanKa
> Priority: Major
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> In the project: openejb-core
> Is in the package: org.apache.openejb.config
> Class: DeploymentsResolver
> Method: loadFromClasspath
> Line: 264
> There is typo there from refactoring done 5 years ago, which prevent us from upgrading.
> Current code:
> {code:java}
> UrlSet unchecked = new UrlSet(); if (!searchResult.filterDescriptors) {
> unchecked = NewLoaderLogic.applyBuiltinExcludes(searchResult.prefiltered.exclude(searchResult.prefiltered));
> if (searchResult.filterSystemApps) {
> unchecked = unchecked.exclude(".*/openejb-[^/]+(.(jar|ear|war)(./)?|/target/classes/?)");
> }
> processUrls("DeploymentsResolver2", unchecked.getUrls(), classLoader, EnumSet.allOf(RequireDescriptors.class), jarList);
> } {code}
> In the exclude should be urlSet instead of prefiltered, otherwice all URL are excluded:
> {code:java}
> unchecked = NewLoaderLogic.applyBuiltinExcludes(searchResult.prefiltered.exclude(searchResult.urlSet));
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)