You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Erik Selin <er...@jadedpixel.com> on 2013/08/18 18:20:56 UTC
Review Request 13636: SQOOP-1170: Can't import columns with name "public"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
Repository: sqoop-trunk
Description
-------
Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
Diffs
-----
src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
Diff: https://reviews.apache.org/r/13636/diff/
Testing
-------
Thanks,
Erik Selin
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Posted by Erik Selin <er...@jadedpixel.com>.
> On Aug. 22, 2013, 10:04 p.m., Jarek Cecho wrote:
> > Please attach the updated patch to the JIRA and I'll commit it.
Added :) https://issues.apache.org/jira/browse/SQOOP-1170
- Erik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25433
-----------------------------------------------------------
On Aug. 19, 2013, 10:59 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 10:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
> src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
> src/test/com/cloudera/sqoop/orm/TestClassWriter.java 358f3fc
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25433
-----------------------------------------------------------
Ship it!
Please attach the updated patch to the JIRA and I'll commit it.
- Jarek Cecho
On Aug. 19, 2013, 10:59 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 10:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
> src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
> src/test/com/cloudera/sqoop/orm/TestClassWriter.java 358f3fc
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Posted by Erik Selin <er...@jadedpixel.com>.
> On Aug. 22, 2013, 3:47 p.m., Jarek Cecho wrote:
> > That is awesome, thank you very much for the changes. I did look at current list of keywords of java on following webpage:
> >
> > http://docs.oracle.com/javase/tutorial/java/nutsandbolts/_keywords.html
> >
> > It seems to me that we are still missing three keywords - false, null and true. Would you mind adding them?
Look again ;)
- Erik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25415
-----------------------------------------------------------
On Aug. 19, 2013, 10:59 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 10:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
> src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
> src/test/com/cloudera/sqoop/orm/TestClassWriter.java 358f3fc
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Posted by Jarek Cecho <ja...@apache.org>.
> On Aug. 22, 2013, 3:47 p.m., Jarek Cecho wrote:
> > That is awesome, thank you very much for the changes. I did look at current list of keywords of java on following webpage:
> >
> > http://docs.oracle.com/javase/tutorial/java/nutsandbolts/_keywords.html
> >
> > It seems to me that we are still missing three keywords - false, null and true. Would you mind adding them?
>
> Erik Selin wrote:
> Look again ;)
Sorry Erik, my quickly written shell sniplet for parsing the values and doing the comparison have obviously some bugs :-)
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25415
-----------------------------------------------------------
On Aug. 19, 2013, 10:59 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 10:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
> src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
> src/test/com/cloudera/sqoop/orm/TestClassWriter.java 358f3fc
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25415
-----------------------------------------------------------
That is awesome, thank you very much for the changes. I did look at current list of keywords of java on following webpage:
http://docs.oracle.com/javase/tutorial/java/nutsandbolts/_keywords.html
It seems to me that we are still missing three keywords - false, null and true. Would you mind adding them?
- Jarek Cecho
On Aug. 19, 2013, 10:59 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 10:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
> src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
> src/test/com/cloudera/sqoop/orm/TestClassWriter.java 358f3fc
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Posted by Erik Selin <er...@jadedpixel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/
-----------------------------------------------------------
(Updated Aug. 19, 2013, 10:59 p.m.)
Review request for Sqoop.
Changes
-------
Add all java reserved keywords as well as tests for each one of them.
Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
Repository: sqoop-trunk
Description
-------
Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
Diffs (updated)
-----
src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
src/test/com/cloudera/sqoop/orm/TestClassWriter.java 358f3fc
Diff: https://reviews.apache.org/r/13636/diff/
Testing
-------
Thanks,
Erik Selin
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Posted by Erik Selin <er...@jadedpixel.com>.
> On Aug. 18, 2013, 7 p.m., Jarek Cecho wrote:
> > Hi Erik,
> > the changes looks about right. Would you mind adding test to TestClassWriter to ensure that we want regress from this functionality?
> >
> > Jarcec
>
> Erik Selin wrote:
> Hey, I sure could but this is such a tiny change I don't really see what you would like me to test for? I could add a line to
>
> assertEquals("_public", ClassWriter.toJavaIdentifier("public"));
>
> but that just seems redundant since we're not testing for any of the other JAVA_RESERVED_WORDS?
>
> Jarek Cecho wrote:
> I think that we actually should be doing exactly that, so If you feel up to, don't hesitate and add the tests for all entries from JAVA_RESERVED_WORDS. Otherwise please just add this one and we will create follow up JIRA to add the others.
This should be even better. I added a test for each keyword, added a few more missing ones and sorted the lists so that they are more manageable.
- Erik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25279
-----------------------------------------------------------
On Aug. 19, 2013, 10:59 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 10:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
> src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
> src/test/com/cloudera/sqoop/orm/TestClassWriter.java 358f3fc
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Posted by Erik Selin <er...@jadedpixel.com>.
> On Aug. 18, 2013, 7 p.m., Jarek Cecho wrote:
> > Hi Erik,
> > the changes looks about right. Would you mind adding test to TestClassWriter to ensure that we want regress from this functionality?
> >
> > Jarcec
Hey, I sure could but this is such a tiny change I don't really see what you would like me to test for? I could add a line to
assertEquals("_public", ClassWriter.toJavaIdentifier("public"));
but that just seems redundant since we're not testing for any of the other JAVA_RESERVED_WORDS?
- Erik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25279
-----------------------------------------------------------
On Aug. 18, 2013, 4:20 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2013, 4:20 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
> src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Posted by Jarek Cecho <ja...@apache.org>.
> On Aug. 18, 2013, 7 p.m., Jarek Cecho wrote:
> > Hi Erik,
> > the changes looks about right. Would you mind adding test to TestClassWriter to ensure that we want regress from this functionality?
> >
> > Jarcec
>
> Erik Selin wrote:
> Hey, I sure could but this is such a tiny change I don't really see what you would like me to test for? I could add a line to
>
> assertEquals("_public", ClassWriter.toJavaIdentifier("public"));
>
> but that just seems redundant since we're not testing for any of the other JAVA_RESERVED_WORDS?
I think that we actually should be doing exactly that, so If you feel up to, don't hesitate and add the tests for all entries from JAVA_RESERVED_WORDS. Otherwise please just add this one and we will create follow up JIRA to add the others.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25279
-----------------------------------------------------------
On Aug. 18, 2013, 4:20 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2013, 4:20 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
> src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25279
-----------------------------------------------------------
Hi Erik,
the changes looks about right. Would you mind adding test to TestClassWriter to ensure that we want regress from this functionality?
Jarcec
- Jarek Cecho
On Aug. 18, 2013, 4:20 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2013, 4:20 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
> src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>