You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/17 08:56:05 UTC

[GitHub] [incubator-superset] maloun96 edited a comment on pull request #12073: [WIP]: refactor : Enable @typescript-eslint/no-explicit-any rule and fix

maloun96 edited a comment on pull request #12073:
URL: https://github.com/apache/incubator-superset/pull/12073#issuecomment-747289403


   > Oh wow, didn't realize we were making this change. After a quick review I realized we have duplicate version of `SavedQuery` and `SavedQueryObject` floating around. Making a note to self to do a pass at type consolidation later. Trying to knockout all the `any`s in a single PR seems very ambitious. Maybe we can just warn at first and then fix all the warnings in follow up PRs, before actually switching to error
   
   Sure, it's in progress, and turned it to error to better see all the "any". I will switch back to warning when it will be done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org