You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ps...@apache.org on 2011/04/24 01:54:44 UTC
svn commit: r1096259 - in
/commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src: changes/changes.xml
java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java
Author: psteitz
Date: Sat Apr 23 23:54:44 2011
New Revision: 1096259
URL: http://svn.apache.org/viewvc?rev=1096259&view=rev
Log:
Changed DelegatingDatabaseMetaData to no longer add itself to the AbandonedTrace of its parent
connection. This was causing excessive memory consumption and was not necessary, as
resultsets created by DelegatingDatabaseMetaData instances are attached to the parent
connection's trace on creation.
JIRA: DBCP-330
JIRA: DBCP-352
Modified:
commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src/changes/changes.xml
commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java
Modified: commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src/changes/changes.xml?rev=1096259&r1=1096258&r2=1096259&view=diff
==============================================================================
--- commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src/changes/changes.xml (original)
+++ commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src/changes/changes.xml Sat Apr 23 23:54:44 2011
@@ -39,6 +39,12 @@ The <action> type attribute can be add,u
</properties>
<body>
<release version="1.4.1" date="TBD" description="TBD">
+ <action dev="psteitz" issue="DBCP-330" type="fix">
+ Changed DelegatingDatabaseMetaData to no longer add itself to the AbandonedTrace
+ of its parent connection. This was causing excessive memory consumption and was
+ not necessary, as resultsets created by DelegatingDatabaseMetaData instances are
+ attached to the parent connection's trace on creation. Also fixes DBCP-352.
+ </action>
<action dev="psteitz" issue="DBCP-343" type="fix">
Modified execute methods of Statement objects to ensure that whenever
a statement is used, the lastUsed property of its parent connection is
Modified: commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java?rev=1096259&r1=1096258&r2=1096259&view=diff
==============================================================================
--- commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java (original)
+++ commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java Sat Apr 23 23:54:44 2011
@@ -26,17 +26,14 @@ import java.sql.RowIdLifetime;
import java.sql.SQLException;
/**
- * A base delegating implementation of {@link DatabaseMetaData}.
- * <p>
- * Those methods that create {@link ResultSet} objects, are wrapped to
+ * <p>A base delegating implementation of {@link DatabaseMetaData}.</p>
+ *
+ * <p>Methods that create {@link ResultSet} objects are wrapped to
* create {@link DelegatingResultSet} objects and the remaining methods
* simply call the corresponding method on the "delegate"
- * provided in my constructor.
- * <p>
- * Extends AbandonedTrace to implement DatabaseMetaData tracking and
- * logging of code which created the DatabaseMetaData. Tracking
- * the DatabaseMetaData ensures that the Connection which created it can
- * close any associated ResultSets on Connection close.
+ * provided in the constructor.</p>
+ *
+ * <p>NOTE: as of version 2.0, this class will no longer extend AbandonedTrace.</p>
*/
public class DelegatingDatabaseMetaData extends AbandonedTrace
implements DatabaseMetaData {
@@ -49,7 +46,7 @@ public class DelegatingDatabaseMetaData
public DelegatingDatabaseMetaData(DelegatingConnection c,
DatabaseMetaData m) {
- super(c);
+ super();
_conn = c;
_meta = m;
}