[Bug 3108] New: The "From foo@bar" line is duplicated when report_safe is 0.

[bu...@bugzilla.spamassassin.org]

http://bugzilla.spamassassin.org/show_bug.cgi?id=3108

           Summary: The "From foo@bar" line is duplicated when report_safe
                    is 0.
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: spamassassin
        AssignedTo: spamassassin-dev@incubator.apache.org
        ReportedBy: koppel@ece.lsu.edu


When configuration option report_safe is set to 0 (just add spam
headers to incoming message) the mbox separator line (From
someone@somewhere.org) appears twice in the output.  

The separator is included in Message::{pristine_headers} by
SpamAssassin::parse and is also stored separately in
Message::{mbox_sep}.  When the message is prepared for output by
PerMsgStatus::rewrite_headers the mbox_sep and pristine_headers values
are both used to construct the message, duplicating the "From " line.

With the patch below the mbox separator is not included in
pristine_headers.  It's worked so far but I'm not 100% sure that it
doesn't break anything or is what the developers planned.  The other
option is to not prepend the mbox line to the message text but I don't
have a patch for that.  (Not that one's needed, given how easy it is
to fix.)



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.