You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/02/04 21:35:32 UTC
[Impala-ASF-CR] IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18199
Change subject: IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
......................................................................
IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
With the recent upgrade of boost to 1.74, CMake's FindBoost
now produces some warnings like:
CMake Warning at cmake-3.14.3/share/cmake-3.14/Modules/FindBoost.cmake:905 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
This upgrades CMake 3.22.2, which has support for newer Boost
versions. With the new CMake, the warning goes away.
This also upgrades ORC to 1.7.0-p6.
Testing:
- Ran core tests
Change-Id: I1d59b346c0def5bbd3580f81438c78dbc16948e7
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/18199/1
--
To view, visit http://gerrit.cloudera.org:8080/18199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d59b346c0def5bbd3580f81438c78dbc16948e7
Gerrit-Change-Number: 18199
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18199 )
Change subject: IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d59b346c0def5bbd3580f81438c78dbc16948e7
Gerrit-Change-Number: 18199
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 09:01:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18199 )
Change subject: IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
......................................................................
IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
With the recent upgrade of boost to 1.74, CMake's FindBoost
now produces some warnings like:
CMake Warning at cmake-3.14.3/share/cmake-3.14/Modules/FindBoost.cmake:905 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
This upgrades CMake 3.22.2, which has support for newer Boost
versions. With the new CMake, the warning goes away.
This also upgrades ORC to 1.7.0-p6.
Testing:
- Ran core tests
Change-Id: I1d59b346c0def5bbd3580f81438c78dbc16948e7
Reviewed-on: http://gerrit.cloudera.org:8080/18199
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Wenzhe Zhou: Looks good to me, approved
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d59b346c0def5bbd3580f81438c78dbc16948e7
Gerrit-Change-Number: 18199
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18199 )
Change subject: IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
......................................................................
Patch Set 1: Code-Review+2
Thanks for picking the new ORC version as well!
--
To view, visit http://gerrit.cloudera.org:8080/18199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d59b346c0def5bbd3580f81438c78dbc16948e7
Gerrit-Change-Number: 18199
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 01:27:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18199 )
Change subject: IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10101/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d59b346c0def5bbd3580f81438c78dbc16948e7
Gerrit-Change-Number: 18199
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 21:59:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18199 )
Change subject: IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7805/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d59b346c0def5bbd3580f81438c78dbc16948e7
Gerrit-Change-Number: 18199
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 02:28:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18199 )
Change subject: IMPALA-11103: Switch to CMake 3.22.2 to avoid boost warnings
......................................................................
Patch Set 1: Code-Review+2
Thanks to fix this warning issue.
--
To view, visit http://gerrit.cloudera.org:8080/18199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d59b346c0def5bbd3580f81438c78dbc16948e7
Gerrit-Change-Number: 18199
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 22:55:07 +0000
Gerrit-HasComments: No