You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Dan Haywood (JIRA)" <ji...@apache.org> on 2012/09/05 20:30:08 UTC
[jira] [Created] (ISIS-264) Add @Paged annotation (for use by
viewer-side paging as a minimum). Implement in Wicket as a minimum
Dan Haywood created ISIS-264:
--------------------------------
Summary: Add @Paged annotation (for use by viewer-side paging as a minimum). Implement in Wicket as a minimum
Key: ISIS-264
URL: https://issues.apache.org/jira/browse/ISIS-264
Project: Isis
Issue Type: New Feature
Components: Core: MetaModel, Core: ProgModel, Viewer: Wicket
Affects Versions: 0.2.0-incubating
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 0.3.1-incubating
@Paged(25) on the type indicates the page size for standalone collections.
@Paged(12) on a collection indicates the page size for parented collections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ISIS-264) Add @Paged annotation (for use by
viewer-side paging as a minimum). Implement in Wicket as a minimum
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood resolved ISIS-264.
------------------------------
Resolution: Fixed
> Add @Paged annotation (for use by viewer-side paging as a minimum). Implement in Wicket as a minimum
> -----------------------------------------------------------------------------------------------------
>
> Key: ISIS-264
> URL: https://issues.apache.org/jira/browse/ISIS-264
> Project: Isis
> Issue Type: New Feature
> Components: Core: MetaModel, Core: ProgModel, Viewer: Wicket
> Affects Versions: 0.2.0-incubating
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 0.3.1-incubating
>
> Attachments: patch.diff
>
>
> @Paged(25) on the type indicates the page size for standalone collections.
> @Paged(12) on a collection indicates the page size for parented collections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (ISIS-264) Add @Paged annotation (for use by
viewer-side paging as a minimum). Implement in Wicket as a minimum
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood reopened ISIS-264:
------------------------------
Jeroen made a suggestion to enhance this a little.
> Add @Paged annotation (for use by viewer-side paging as a minimum). Implement in Wicket as a minimum
> -----------------------------------------------------------------------------------------------------
>
> Key: ISIS-264
> URL: https://issues.apache.org/jira/browse/ISIS-264
> Project: Isis
> Issue Type: New Feature
> Components: Core: MetaModel, Core: ProgModel, Viewer: Wicket
> Affects Versions: 0.2.0-incubating
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 0.3.1-incubating
>
>
> @Paged(25) on the type indicates the page size for standalone collections.
> @Paged(12) on a collection indicates the page size for parented collections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ISIS-264) Add @Paged annotation (for use by
viewer-side paging as a minimum). Implement in Wicket as a minimum
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood resolved ISIS-264.
------------------------------
Resolution: Fixed
> Add @Paged annotation (for use by viewer-side paging as a minimum). Implement in Wicket as a minimum
> -----------------------------------------------------------------------------------------------------
>
> Key: ISIS-264
> URL: https://issues.apache.org/jira/browse/ISIS-264
> Project: Isis
> Issue Type: New Feature
> Components: Core: MetaModel, Core: ProgModel, Viewer: Wicket
> Affects Versions: 0.2.0-incubating
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 0.3.1-incubating
>
>
> @Paged(25) on the type indicates the page size for standalone collections.
> @Paged(12) on a collection indicates the page size for parented collections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ISIS-264) Add @Paged annotation (for use by
viewer-side paging as a minimum). Implement in Wicket as a minimum
Posted by "Jeroen van der Wal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeroen van der Wal updated ISIS-264:
------------------------------------
Attachment: patch.diff
Added support to use defaults stored in isis.properties. This is an example:
isis.viewers.paged.standalone=20
isis.viewers.paged.parented=5
> Add @Paged annotation (for use by viewer-side paging as a minimum). Implement in Wicket as a minimum
> -----------------------------------------------------------------------------------------------------
>
> Key: ISIS-264
> URL: https://issues.apache.org/jira/browse/ISIS-264
> Project: Isis
> Issue Type: New Feature
> Components: Core: MetaModel, Core: ProgModel, Viewer: Wicket
> Affects Versions: 0.2.0-incubating
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 0.3.1-incubating
>
> Attachments: patch.diff
>
>
> @Paged(25) on the type indicates the page size for standalone collections.
> @Paged(12) on a collection indicates the page size for parented collections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ISIS-264) Add @Paged annotation (for use by
viewer-side paging as a minimum). Implement in Wicket as a minimum
Posted by "Jeroen van der Wal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449020#comment-13449020 ]
Jeroen van der Wal commented on ISIS-264:
-----------------------------------------
It would be nice to set defaults through isis.properties. Something like:
isis.viewers.paged.standalone=30
isis.viewers.paged.parented=10
> Add @Paged annotation (for use by viewer-side paging as a minimum). Implement in Wicket as a minimum
> -----------------------------------------------------------------------------------------------------
>
> Key: ISIS-264
> URL: https://issues.apache.org/jira/browse/ISIS-264
> Project: Isis
> Issue Type: New Feature
> Components: Core: MetaModel, Core: ProgModel, Viewer: Wicket
> Affects Versions: 0.2.0-incubating
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 0.3.1-incubating
>
>
> @Paged(25) on the type indicates the page size for standalone collections.
> @Paged(12) on a collection indicates the page size for parented collections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (ISIS-264) Add @Paged annotation (for use
by viewer-side paging as a minimum). Implement in Wicket as a minimum
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459674#comment-13459674 ]
Dan Haywood edited comment on ISIS-264 at 9/21/12 4:20 AM:
-----------------------------------------------------------
Patch applied, thanks.
A few fixes/clarifications (that I've made):
* the FallbackFacetFactory will always end up installing a PagedFacet if there is no @Paged annotation (agreed offline). There's therefore no need for default handling for the PagedAnnotationOnXxxFacetFactory ... may as well insist that value() is mandatory after all
* in PagedAnnotationOnTypeFacetFactory, the processMethod() call is redundant ... it will never be called. Have removed.
* ditto, in PagedAnnotationOnCollectionFacetFactory, the processClass() call is redundant ... it will never be called. Have removed.
* the @Paged annotation is not required on the above FacetFactory impls
* in the FallbackFacetFactory where do getConfiguration().getInteger(...), have provided a default value in case there is none in the isis.properties (otherwise would be value zero).
* typo in isis-applib.xml
commits: r1388083 and r1388119
was (Author: danhaywood):
Patch applied, thanks.
A few fixes/clarifications (that I've made):
* the FallbackFacetFactory will always end up installing a PagedFacet if there is no @Paged annotation (agreed offline). There's therefore no need for default handling for the PagedAnnotationOnXxxFacetFactory ... may as well insist that value() is mandatory after all
* in PagedAnnotationOnTypeFacetFactory, the processMethod() call is redundant ... it will never be called. Have removed.
* ditto, in PagedAnnotationOnCollectionFacetFactory, the processClass() call is redundant ... it will never be called. Have removed.
* the @Paged annotation is not required on the above FacetFactory impls
* in the FallbackFacetFactory where do getConfiguration().getInteger(...), have provided a default value in case there is none in the isis.properties (otherwise would be value zero).
* typo in isis-applib.xml
> Add @Paged annotation (for use by viewer-side paging as a minimum). Implement in Wicket as a minimum
> -----------------------------------------------------------------------------------------------------
>
> Key: ISIS-264
> URL: https://issues.apache.org/jira/browse/ISIS-264
> Project: Isis
> Issue Type: New Feature
> Components: Core: MetaModel, Core: ProgModel, Viewer: Wicket
> Affects Versions: 0.2.0-incubating
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 0.3.1-incubating
>
> Attachments: patch.diff
>
>
> @Paged(25) on the type indicates the page size for standalone collections.
> @Paged(12) on a collection indicates the page size for parented collections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ISIS-264) Add @Paged annotation (for use by
viewer-side paging as a minimum). Implement in Wicket as a minimum
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459674#comment-13459674 ]
Dan Haywood commented on ISIS-264:
----------------------------------
Patch applied, thanks.
A few fixes/clarifications (that I've made):
* the FallbackFacetFactory will always end up installing a PagedFacet if there is no @Paged annotation (agreed offline). There's therefore no need for default handling for the PagedAnnotationOnXxxFacetFactory ... may as well insist that value() is mandatory after all
* in PagedAnnotationOnTypeFacetFactory, the processMethod() call is redundant ... it will never be called. Have removed.
* ditto, in PagedAnnotationOnCollectionFacetFactory, the processClass() call is redundant ... it will never be called. Have removed.
* the @Paged annotation is not required on the above FacetFactory impls
* in the FallbackFacetFactory where do getConfiguration().getInteger(...), have provided a default value in case there is none in the isis.properties (otherwise would be value zero).
* typo in isis-applib.xml
> Add @Paged annotation (for use by viewer-side paging as a minimum). Implement in Wicket as a minimum
> -----------------------------------------------------------------------------------------------------
>
> Key: ISIS-264
> URL: https://issues.apache.org/jira/browse/ISIS-264
> Project: Isis
> Issue Type: New Feature
> Components: Core: MetaModel, Core: ProgModel, Viewer: Wicket
> Affects Versions: 0.2.0-incubating
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 0.3.1-incubating
>
> Attachments: patch.diff
>
>
> @Paged(25) on the type indicates the page size for standalone collections.
> @Paged(12) on a collection indicates the page size for parented collections.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira