You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/22 20:32:06 UTC

[GitHub] [arrow] nevi-me commented on a change in pull request #9771: ARROW-12043: [Rust] [Parquet] Write FSB arrays

nevi-me commented on a change in pull request #9771:
URL: https://github.com/apache/arrow/pull/9771#discussion_r599053605



##########
File path: rust/parquet/src/arrow/arrow_writer.rs
##########
@@ -156,6 +156,16 @@ fn write_leaves(
             row_group_writer.close_column(col_writer)?;
             Ok(())
         }
+        ArrowDataType::FixedSizeBinary(_) => {
+            let mut col_writer = get_col_writer(&mut row_group_writer)?;
+            write_leaf(
+                &mut col_writer,
+                array,
+                levels.pop().expect("Levels exhausted"),
+            )?;
+            row_group_writer.close_column(col_writer)?;
+            Ok(())
+        }

Review comment:
       lol, there isn't. Someone (won't name them) copied this chunk separately, thinking that it'll be different. Then they forgot to merge it when they realised that there was no difference.
   
   I'll fix it shortly




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org