You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/07 21:58:14 UTC
[GitHub] [superset] dd-willgan opened a new pull request #16627: #16625 Provide option to add environment variables to only supersetNode
dd-willgan opened a new pull request #16627:
URL: https://github.com/apache/superset/pull/16627
### SUMMARY
I'm adding an option to only add env variables to the main supersetNode pod through the Helm chart. See #16625.
### TESTING INSTRUCTIONS
I added some test values in `values.yaml` and confirmed that they were being read properly locally.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #16625
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #16627: other: Provide option to add environment variables to only supersetNode
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #16627:
URL: https://github.com/apache/superset/pull/16627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #16627: other: Provide option to add environment variables to only supersetNode
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #16627:
URL: https://github.com/apache/superset/pull/16627#discussion_r711200786
##########
File path: helm/superset/templates/deployment.yaml
##########
@@ -79,6 +79,12 @@ spec:
value: {{ $value | quote }}
{{- end }}
{{- end }}
+ {{- if .Values.supersetNode.env }}
Review comment:
is this if necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dd-willgan commented on a change in pull request #16627: other: Provide option to add environment variables to only supersetNode
Posted by GitBox <gi...@apache.org>.
dd-willgan commented on a change in pull request #16627:
URL: https://github.com/apache/superset/pull/16627#discussion_r711266605
##########
File path: helm/superset/templates/deployment.yaml
##########
@@ -79,6 +79,12 @@ spec:
value: {{ $value | quote }}
{{- end }}
{{- end }}
+ {{- if .Values.supersetNode.env }}
Review comment:
@dpgaspar No but after thinking about it I would prefer to keep it to match how extraEnv is read in this file and others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org